Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support dark dataset test #815

Merged
merged 19 commits into from
Aug 28, 2021
Merged

Conversation

xiexinch
Copy link
Collaborator

@xiexinch xiexinch commented Aug 24, 2021

Motivation

Support Dark Zurich and Nighttime Driving datasets test.

Dark Zurich

Method Backbone mIoU
PSPNet R-50-D8 10.91
PSPNet R-101-D8 10.16
PSPNet R-101b-D8 15.54

Nighttime Driving

Method Backbone mIoU
PSPNet R-50-D8 23.02
PSPNet R-101-D8 20.25
PSPNet R-101b-D8 22.25

dependency

#750

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #815 (6adf08b) into master (e235c1a) will increase coverage by 1.12%.
The diff coverage is 86.36%.

❗ Current head 6adf08b differs from pull request most recent head be5a3b1. Consider uploading reports for the commit be5a3b1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
+ Coverage   87.64%   88.76%   +1.12%     
==========================================
  Files         108      109       +1     
  Lines        5886     5823      -63     
  Branches      958      935      -23     
==========================================
+ Hits         5159     5169      +10     
+ Misses        535      463      -72     
+ Partials      192      191       -1     
Flag Coverage Δ
unittests 88.75% <86.36%> (+1.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/utils/__init__.py 100.00% <ø> (ø)
mmseg/models/backbones/hrnet.py 84.37% <80.00%> (+1.04%) ⬆️
mmseg/datasets/dark_zurich.py 83.33% <83.33%> (ø)
mmseg/datasets/night_driving.py 83.33% <83.33%> (ø)
mmseg/datasets/__init__.py 100.00% <100.00%> (ø)
mmseg/datasets/cityscapes.py 85.00% <100.00%> (ø)
mmseg/models/backbones/swin.py 87.41% <100.00%> (+0.51%) ⬆️
mmseg/models/backbones/vit.py 86.79% <100.00%> (+1.94%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e235c1a...be5a3b1. Read the comment docs.

@Junjun2016
Copy link
Collaborator

Could you please provide some baseline results in the corresponding paper?
Add to PR message.

@Junjun2016
Copy link
Collaborator

Junjun2016 commented Aug 25, 2021

@xiexinch
Copy link
Collaborator Author

xiexinch commented Aug 26, 2021

Hi @xiexinch
Please

What information should be added to README.md at the root? I didn't implement any new methods.

@Junjun2016
Copy link
Collaborator

Hi @xiexinch
Please

What information should be added to README.md at the root? I didn't implement any new methods.

Typo: Supported methods --> Supported datasets
We can add an item named Supported datasets.

README.md Outdated Show resolved Hide resolved
@MengzhangLI
Copy link
Contributor

Hi, @xiexinch

I just changed your table in PSPNet config, please check it out.

Best,

Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xvjiarui xvjiarui merged commit 5753f41 into open-mmlab:master Aug 28, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* rewrite init function

* support dark_zurich test

* reset image size

* add night

* add train_pipeline

* init function parameters

* remove base dataset config

* remove fcn config

* update doc

* add datasets to README

* update doc

* fix table of PSPNet config

* fix table of PSPNet config

* change 'model' tp 'evaluation checkpoint'

* fix typos in README_zh-CN

Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this pull request Mar 27, 2023
* Give more customizable options for safety checker

* Apply suggestions from code review

* Update src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion.py

* Finish

* make style

* Apply suggestions from code review

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>

* up

Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants