Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix_torchserver1.1 #844

Merged
merged 10 commits into from Sep 23, 2021
Merged

Conversation

VVsssssk
Copy link
Contributor

@VVsssssk VVsssssk commented Sep 2, 2021

Hi,when I try to test mmseg's torchserver function,i find some problems that casue server can't run.So,I fix problem and write a python script to test function.

  • 1,when I use cpu env to inference a fcn model

2021-08-31 07:34:25,801 [INFO ] W-9006-fcn_1.0-stdout MODEL_LOG - raise ValueError('SyncBatchNorm expected input tensor to be on GPU')
2021-08-31 07:34:25,801 [INFO ] W-9006-fcn_1.0-stdout MODEL_LOG - ValueError: SyncBatchNorm expected input tensor to be on GPU

  • 2,in postprocess output result to json

2021-08-31 07:58:56,594 [INFO ] W-9000-fcn_1.0-stdout MODEL_LOG - Unable to serialize model output.
2021-08-31 07:58:56,595 [INFO ] W-9000-fcn_1.0-stdout MODEL_LOG - raise TypeError(f'Object of type {o.class.name} '
2021-08-31 07:58:56,595 [INFO ] W-9000-fcn_1.0-stdout MODEL_LOG - TypeError: Object of type ndarray is not JSON serializable

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2021

CLA assistant check
All committers have signed the CLA.

@Junjun2016
Copy link
Collaborator

Junjun2016 commented Sep 2, 2021

Hi @VVsssssk
Thanks for your contribution.
We can import synbn2bn from mmcv after it merged.
Please refer to #772.

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #844 (ba0747f) into master (4e6f2eb) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   89.05%   89.05%   -0.01%     
==========================================
  Files         111      112       +1     
  Lines        6051     6060       +9     
  Branches      969      970       +1     
==========================================
+ Hits         5389     5397       +8     
- Misses        467      468       +1     
  Partials      195      195              
Flag Coverage Δ
unittests 89.05% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/__init__.py 100.00% <0.00%> (ø)
mmseg/datasets/coco_stuff.py 87.50% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e6f2eb...ba0747f. Read the comment docs.

@RunningLeon
Copy link
Collaborator

@VVsssssk Could fix conflicts at first.

@Junjun2016
Copy link
Collaborator

@zhouzaida
When will syncbn2bn merge in mmcv?
And maybe mmcv should also support bn2syncbn.

@Junjun2016
Copy link
Collaborator

Can import revert_sync_batchnorm from open-mmlab/mmcv#1253

@RunningLeon
Copy link
Collaborator

Can import revert_sync_batchnorm from open-mmlab/mmcv#1253

@VVsssssk Hi, may update accordingly.

@Junjun2016
Copy link
Collaborator

Hi @VVsssssk
Could you please update this PR.

docs/useful_tools.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the comments.

@Junjun2016
Copy link
Collaborator

Please also resolve the conflict.

Copy link
Collaborator

@Junjun2016 Junjun2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Junjun2016
Copy link
Collaborator

Hi @RunningLeon
Please review it again.

docs/useful_tools.md Outdated Show resolved Hide resolved
docs/useful_tools.md Outdated Show resolved Hide resolved
docs/useful_tools.md Outdated Show resolved Hide resolved
docs/useful_tools.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Junjun2016 Junjun2016 merged commit 0b11d58 into open-mmlab:master Sep 23, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* test_torchserver1.1

* test_torchserver1.2

* update

* update mmseg_handler.py

* update docs

* update torchserver

* tranfer torchserver to torchserve

* update docs
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants