Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] barlowtwins #207

Merged
merged 34 commits into from Apr 27, 2022
Merged

[Feature] barlowtwins #207

merged 34 commits into from Apr 27, 2022

Conversation

xcnick
Copy link
Contributor

@xcnick xcnick commented Feb 8, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

This PR implements barlow twins algorithm.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #207 (86319d7) into dev_v0.9.0 (ed31de7) will increase coverage by 0.25%.
The diff coverage is 96.15%.

@@              Coverage Diff               @@
##           dev_v0.9.0     #207      +/-   ##
==============================================
+ Coverage       70.05%   70.30%   +0.25%     
==============================================
  Files             113      114       +1     
  Lines            4051     4099      +48     
  Branches          655      658       +3     
==============================================
+ Hits             2838     2882      +44     
- Misses           1089     1092       +3     
- Partials          124      125       +1     
Flag Coverage Δ
unittests 70.30% <96.15%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmselfsup/models/heads/latent_pred_head.py 95.83% <92.00%> (-4.17%) ⬇️
mmselfsup/models/algorithms/__init__.py 100.00% <100.00%> (ø)
mmselfsup/models/algorithms/barlowtwins.py 100.00% <100.00%> (ø)
mmselfsup/models/heads/__init__.py 100.00% <100.00%> (ø)
mmselfsup/datasets/utils.py 36.84% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed31de7...86319d7. Read the comment docs.

@xcnick xcnick changed the title [Feature]: barlowtwins [Feature] barlowtwins Feb 8, 2022
Copy link
Collaborator

@fangyixiao18 fangyixiao18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Do you have any results or models of barlowtwins based on this PR?

@xcnick
Copy link
Contributor Author

xcnick commented Feb 9, 2022

Thank you for your contribution. Do you have any results or models of barlowtwins based on this PR?

Sorry, due to lack of computing resources, I only performed the pretraining steps on RTX2080Ti * 2, and observed loss decreasing. Therefore, the config parameters may need to be further adjusted.

I will use 4 * V100 to verify this PR later if possible.

@fangyixiao18
Copy link
Collaborator

Sorry, due to lack of computing resources, I only performed the pretraining steps on RTX2080Ti * 2, and observed loss decreasing. Therefore, the config parameters may need to be further adjusted.

I will use 4 * V100 to verify this PR later if possible.

OK, can you checkout a new branch from dev_v0.7.0 and re-create a PR to the dev_v0.7.0 branch? And if you have any updated results, you can push new commits to the new PR.
We look forward that your PR can be merged and the BarlowTwins can be released in version 0.7.0 at the begining of the next month.

@xcnick
Copy link
Contributor Author

xcnick commented Feb 10, 2022

Sorry, due to lack of computing resources, I only performed the pretraining steps on RTX2080Ti * 2, and observed loss decreasing. Therefore, the config parameters may need to be further adjusted.
I will use 4 * V100 to verify this PR later if possible.

OK, can you checkout a new branch from dev_v0.7.0 and re-create a PR to the dev_v0.7.0 branch? And if you have any updated results, you can push new commits to the new PR. We look forward that your PR can be merged and the BarlowTwins can be released in version 0.7.0 at the begining of the next month.

OK.

@xcnick xcnick changed the base branch from master to dev_v0.7.0 March 1, 2022 03:50
@xcnick
Copy link
Contributor Author

xcnick commented Mar 1, 2022

Using the parameters in the code for pretraining in 4*V100, the loss value is about 2000. The top1 acc is 40% when finetune in imagenet1k. So the model did not converge.
Could you help me for the model training?

@YuanLiuuuuuu
Copy link
Collaborator

Using the parameters in the code for pretraining in 4*V100, the loss value is about 2000. The top1 acc is 40% when finetune in imagenet1k. So the model did not converge. Could you help me for the model training?

Using the parameters in the code for pretraining in 4*V100, the loss value is about 2000. The top1 acc is 40% when finetune in imagenet1k. So the model did not converge. Could you help me for the model training?

If you do not have enough computation resources, you can choose a setting, which has lower computation overhead. Under this setting, you can run the official code and get the log. Finally, you can reproduce the results, according to the log.

@YuanLiuuuuuu
Copy link
Collaborator

We have already created a new branch, dev_v0.8.0, for next released version. Please re-submit a PR to merge all your modifications to that branch as soon as possible. Thanks a lot !

YuanLiuuuuuu and others added 4 commits March 9, 2022 18:02
* [Feature]: Add multi machine dist_train

* [Fix]: Change bash to sh

* [Fix]: Fix missing sh suffix

* [Refactor]: Change bash to sh
* [Refactor] add unit test

* update workflow

* update

* [Fix] fix lint

* update test

* refactor moco and densecl unit test

* fix lint

* add unit test

* update unit test

* remove modification
* [Feature]: Add MAE metafile

* [Fix]: Fix lint

* [Fix]: Change LARS to AdamW in the metafile of MAE
@xcnick xcnick changed the base branch from dev_v0.7.0 to dev_v0.8.0 March 14, 2022 08:18
@YuanLiuuuuuu
Copy link
Collaborator

Using the parameters in the code for pretraining in 4*V100, the loss value is about 2000. The top1 acc is 40% when finetune in imagenet1k. So the model did not converge. Could you help me for the model training?

Please add the same decorator to your algorithm to pass CI.

@fangyixiao18
Copy link
Collaborator

Do you have any updated training results?

@xcnick
Copy link
Contributor Author

xcnick commented Mar 29, 2022

Do you have any updated training results?

Sorry, the learning rate parameter is adjusted according to the official code, but the loss is around 2000. In contrast, the loss is around 500 in official log when training epoch is 100.

@YuanLiuuuuuu YuanLiuuuuuu changed the base branch from dev_v0.8.0 to dev_v0.9.0 April 1, 2022 05:44
Copy link
Collaborator

@Jiahao000 Jiahao000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to reorganize the algorithms in model zoo in their chronological order. Others LGTM.

docs/en/model_zoo.md Show resolved Hide resolved
@YuanLiuuuuuu
Copy link
Collaborator

@fangyixiao18 Please update index.rst in docs

@Jiahao000 Jiahao000 merged commit c525544 into open-mmlab:dev_v0.9.0 Apr 27, 2022
fangyixiao18 added a commit that referenced this pull request Apr 29, 2022
* [Feature]: MAE pre-training with fp16 (#271)

* [Feature]: MAE pre-training with fp16

* [Fix]: Fix lint

* [Fix]: Fix SimMIM config link, and add SimMIM to model_zoo (#272)

* [Fix]: Fix link error

* [Fix]: Add SimMIM to model zoo

* [Fix]: Fix lint

* [Fix] fix 'no init_cfg' error for pre-trained model backbones (#256)

* [UT] add unit test for apis (#276)

* [UT] add unit test for apis

* ignore pytest log

* [Feature] Add extra dataloader settings in configs. (#264)

* [Feature] support to set validation samples per gpu independently

* set default to be cfg.data.samples_per_gpu

* modify the tools/test.py

* using 'train_dataloader', 'val_dataloader', 'test_dataloader' for specific settings

* test 'evaluation' branch

* [Fix]: Change imgs_per_gpu to samples_per_gpu MAE (#278)

* [Feature]: Add SimMIM 192 pt 224 ft (#280)

* [Feature]: Add SimMIM 192 pt 224 ft

* [Feature]: Add simmim 192 pt 224 ft to readme

* [Fix] fix key error bug when registering custom hooks (#273)

* [UT] remove pytorch1.5 test (#288)

* [Benchmark] rename linear probing config file names (#281)

* [Benchmark] rename linear probing config file names

* update config links

* Avoid GPU memory leak with prefetch dataloader (#277)

* [Feature] barlowtwins (#207)

* [Fix]: Fix mmcls upgrade bug (#235)

* [Feature]: Add multi machine dist_train (#232)

* [Feature]: Add multi machine dist_train

* [Fix]: Change bash to sh

* [Fix]: Fix missing sh suffix

* [Refactor]: Change bash to sh

* [Refactor] Add unit test (#234)

* [Refactor] add unit test

* update workflow

* update

* [Fix] fix lint

* update test

* refactor moco and densecl unit test

* fix lint

* add unit test

* update unit test

* remove modification

* [Feature]: Add MAE metafile (#238)

* [Feature]: Add MAE metafile

* [Fix]: Fix lint

* [Fix]: Change LARS to AdamW in the metafile of MAE

* Add barlowtwins

* Add unit test for barlowtwins

* Adjust training params

* add decorator to pass CI

* adjust params

* Add barlowtwins

* Add unit test for barlowtwins

* Adjust training params

* add decorator to pass CI

* adjust params

* add barlowtwins configs

* revise LatentCrossCorrelationHead

* modify ut to save memory

* add metafile

* add barlowtwins results to model zoo

* add barlow twins to homepage

* fix batch size bug

* add algorithm readme

* add type hints

* reorganize the model zoo

* remove one config

* recover the config

* add missing docstring

* revise barlowtwins

* reorganize coco and voc benchmark

* add barlowtwins to index.rst

* revise docstring

Co-authored-by: Yuan Liu <30762564+YuanLiuuuuuu@users.noreply.github.com>
Co-authored-by: Yixiao Fang <36138628+fangyixiao18@users.noreply.github.com>
Co-authored-by: fangyixiao18 <fangyx18@hotmail.com>

* [Fix] fix --local-rank (#290)

* [UT] reduce memory usage while runing unit test (#291)

* [Feature]: CAE Supported (#284)

* [Feature]: Add mc

* [Feature]: Add dataset of CAE

* [Feature]: Init version of CAE

* [Feature]: Add mc

* [Fix]: Change beta to (0.9, 0.999)

* [Fix]: New feature

* [Fix]: Decouple the qkv bias

* [Feature]: Decouple qkv bias in MultiheadAttention

* [Feature]: New mask generator

* [Fix]: Fix TransformEncoderLayer bug

* [Feature]: Add MAE CAE linear prob

* [Fix]: Fix config

* [Fix]: Delete redundant mc

* [Fix]: Add init value in mim cls vit

* [Fix]: Fix cae ft config

* [Fix]: Delete repeated init_values

* [Fix]: Change bs from 64 to 128 in CAE ft

* [Fix]: Add mc in cae pt

* [Fix]: Fix momemtum update bug

* [Fix]: Add no weight_decay for gamma

* [Feature]: Add mc for cae pt

* [Fix]: Delete mc

* [Fix]: Delete redundant files

* [Fix]: Fix lint

* [Feature]: Add docstring to algo, backbone, neck and head

* [Fix]: Fix lint

* [Fix]: network

* [Feature]: Add docstrings for network blocks

* [Feature]: Add docstring to ToTensor

* [Feature]: Add docstring to transoform

* [Fix]: Add type hint to BEiTMaskGenerator

* [Fix]: Fix lint

* [Fix]: Add copyright to dalle_e

* [Fix]: Fix BlockwiseMaskGenerator

* [Feature]: Add UT for CAE

* [Fix]: Fix dalle state_dict path not existed bug

* [Fix]: Delete file_client_args related code

* [Fix]: Remove redundant code

* [Refactor]: Add fp16 to the name of cae pre-train config

* [Refactor]: Use FFN from mmcv

* [Refactor]: Change network_blocks to trasformer_blocks

* [Fix]: Fix mask generator name bug

* [Fix]: cae pre-train config bug

* [Fix]: Fix docstring grammar

* [Fix]: Fix mc related code

* [Fix]: Add object parent to transform

* [Fix]: Delete unnecessary modification

* [Fix]: Change blockwisemask generator to simmim mask generator

* [Refactor]: Change cae mae pretrain vit to cae mae vit

* [Refactor]: Change lamb to lambd

* [Fix]: Remove blank line

* [Fix]: Fix lint

* [Fix]: Fix UT

* [Fix]: Delete modification to swin

* [Fix]: Fix lint

* [Feature]: Add README and metafile

* [Feature]: Update index.rst

* [Fix]: Update model_zoo

* [Fix]: Change MAE to CAE in algorithm

* [Fix]: Change SimMIMMaskGenerator to CAEMaskGenerator

* [Fix]: Fix model zoo

* [Fix]: Change to dalle_encoder

* [Feature]: Add download link for dalle

* [Fix]: Fix lint

* [Fix]: Fix UT

* [Fix]: Update metafile

* [Fix]: Change b to base

* [Feature]: Add dalle download link in warning

* [Fix] add arxiv link in readme

Co-authored-by: Jiahao Xie <52497952+Jiahao000@users.noreply.github.com>

* [Enhance] update SimCLR models and results (#295)

* [Enhance] update simclr models and results

* [Fix] revise comments to indicate settings

* Update version (#296)

* [Feature]: Update to 0.9.0

* [Feature]: Add version constrain for mmcls

* [Fix]: Fix bug

* [Fix]: Fix version bug

* [Feature]: Update version in install.md

* update changelog

* update readme

* [Fix] fix uppercase

* [Fix] fix uppercase

* [Fix] fix uppercase

* update version dependency

* add cae to readme

Co-authored-by: fangyixiao18 <fangyx18@hotmail.com>
Co-authored-by: Jiahao Xie <52497952+Jiahao000@users.noreply.github.com>

Co-authored-by: Yixiao Fang <36138628+fangyixiao18@users.noreply.github.com>
Co-authored-by: Ming Li <73068772+mitming@users.noreply.github.com>
Co-authored-by: xcnick <xcnick0412@gmail.com>
Co-authored-by: fangyixiao18 <fangyx18@hotmail.com>
Co-authored-by: Jiahao Xie <52497952+Jiahao000@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants