Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Add advanced_guides/engine.md #454

Merged
merged 11 commits into from Sep 7, 2022
Merged

[Docs]: Add advanced_guides/engine.md #454

merged 11 commits into from Sep 7, 2022

Conversation

soonera
Copy link
Contributor

@soonera soonera commented Aug 29, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add advanced_guides/engine.md

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@soonera soonera added Documentation Improvements or additions to documentation dev-1.x labels Aug 29, 2022
Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As inline comments

docs/en/advanced_guides/engine.md Show resolved Hide resolved
docs/en/advanced_guides/engine.md Outdated Show resolved Hide resolved
docs/en/advanced_guides/engine.md Outdated Show resolved Hide resolved
docs/en/advanced_guides/engine.md Outdated Show resolved Hide resolved
docs/en/advanced_guides/engine.md Outdated Show resolved Hide resolved
docs/en/advanced_guides/engine.md Outdated Show resolved Hide resolved
@fangyixiao18 fangyixiao18 merged commit 2fc5376 into dev-1.x Sep 7, 2022
@fangyixiao18 fangyixiao18 deleted the rq/docs_engine branch September 13, 2022 07:53
fangyixiao18 pushed a commit that referenced this pull request Oct 12, 2022
* [Docs]: Add advanced_guides/engine.md

* [Docs]:Add advanced_guides/engine.md

* [Docs]: Add advanced_guides/engine.md

* [Docs]: Add advanced_guides/engine.md

* [Fix]: fix lint

* [Fix]: fix some parts in doc

* [Fix]: change link to api doc

* [Fix]: change link to api doc

* [Refactor]: refactor docs/en/advanced_guides/engine.md

* [Fix]: fix lint

* [Fix]: replace link
fangyixiao18 pushed a commit that referenced this pull request Oct 12, 2022
* [Docs]: Add advanced_guides/engine.md

* [Docs]:Add advanced_guides/engine.md

* [Docs]: Add advanced_guides/engine.md

* [Docs]: Add advanced_guides/engine.md

* [Fix]: fix lint

* [Fix]: fix some parts in doc

* [Fix]: change link to api doc

* [Fix]: change link to api doc

* [Refactor]: refactor docs/en/advanced_guides/engine.md

* [Fix]: fix lint

* [Fix]: replace link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-1.x Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants