Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Maskfeat-1.x Support #494

Merged
merged 29 commits into from Nov 1, 2022

Conversation

daidaiershidi
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add maskfeat support.

Modification

Add MaskGenerator.
Add backbone of maskfeat.
Add head of maskfeat.
Add algorithms of maskfeat.
Add config of maskfeat.
Add Config of MaskFeat.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 81.41% // Head: 82.16% // Increases project coverage by +0.74% 🎉

Coverage data is based on head (d1ea8b0) compared to base (3e3b315).
Patch coverage: 94.95% of modified lines in pull request are covered.

❗ Current head d1ea8b0 differs from pull request most recent head 797cf79. Consider uploading reports for the commit 797cf79 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x     #494      +/-   ##
===========================================
+ Coverage    81.41%   82.16%   +0.74%     
===========================================
  Files          113      118       +5     
  Lines         3961     4178     +217     
  Branches       563      605      +42     
===========================================
+ Hits          3225     3433     +208     
- Misses         627      631       +4     
- Partials       109      114       +5     
Flag Coverage Δ
unittests 82.16% <94.95%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmselfsup/datasets/transforms/wrappers.py 100.00% <ø> (ø)
mmselfsup/models/backbones/simmim_swin.py 86.95% <ø> (ø)
mmselfsup/models/heads/maskfeat_head.py 90.00% <90.00%> (ø)
mmselfsup/datasets/transforms/processing.py 89.76% <92.59%> (+0.32%) ⬆️
mmselfsup/models/utils/hog_layer.py 93.22% <93.22%> (ø)
mmselfsup/models/backbones/maskfeat_vit.py 97.61% <97.61%> (ø)
mmselfsup/datasets/transforms/__init__.py 100.00% <100.00%> (ø)
mmselfsup/models/algorithms/__init__.py 100.00% <100.00%> (ø)
mmselfsup/models/algorithms/maskfeat.py 100.00% <100.00%> (ø)
mmselfsup/models/backbones/__init__.py 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyixiao18 fangyixiao18 merged commit a1f1dad into open-mmlab:dev-1.x Nov 1, 2022
fangyixiao18 added a commit that referenced this pull request Nov 3, 2022
* [Feature]: Add MaskfeatMaskGenerator Pipeline

* [Feature]: Add MaskFeatMaskGenerator Pipeline

* [Feature]: Add Backbone of MaskFeat

* [Feature]: Add HogLayerC for MaskFeat

* [Feature]: Add Loss of MaskFeat

* [Feature]: Add Head of MaskFeat

* [Feature]: Add Algorithms of MaskFeat

* [Feature]: Add Config of MaskFeat

* [Fix] fix ut of MaskFeatMaskGenerator

* refine configs

* update

* refactor to support hog generator

* update config

* update

* update config and metafiel

* update maskfeat model link

* fix ut

* refine codes

* fix lint

* refine docstring

* refactor maskfeat head

* update model links

* fix ut

* refine docstring

* update model-index

* using BEiTMaskGenerator

* refine configs

* update ut

* fix lint

Co-authored-by: fangyixiao18 <fangyx18@hotmail.com>
fangyixiao18 added a commit that referenced this pull request Nov 3, 2022
* [Feature]: Add MaskfeatMaskGenerator Pipeline

* [Feature]: Add MaskFeatMaskGenerator Pipeline

* [Feature]: Add Backbone of MaskFeat

* [Feature]: Add HogLayerC for MaskFeat

* [Feature]: Add Loss of MaskFeat

* [Feature]: Add Head of MaskFeat

* [Feature]: Add Algorithms of MaskFeat

* [Feature]: Add Config of MaskFeat

* [Fix] fix ut of MaskFeatMaskGenerator

* refine configs

* update

* refactor to support hog generator

* update config

* update

* update config and metafiel

* update maskfeat model link

* fix ut

* refine codes

* fix lint

* refine docstring

* refactor maskfeat head

* update model links

* fix ut

* refine docstring

* update model-index

* using BEiTMaskGenerator

* refine configs

* update ut

* fix lint

Co-authored-by: fangyixiao18 <fangyx18@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants