Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Refine configs #547

Merged
merged 12 commits into from Oct 31, 2022
Merged

Conversation

fangyixiao18
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 81.39% // Head: 81.44% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (39bb5a8) compared to base (89118a8).
Patch has no changes to coverable lines.

❗ Current head 39bb5a8 differs from pull request most recent head 9b9cf91. Consider uploading reports for the commit 9b9cf91 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x     #547      +/-   ##
===========================================
+ Coverage    81.39%   81.44%   +0.05%     
===========================================
  Files          113      113              
  Lines         3961     3961              
  Branches       563      563              
===========================================
+ Hits          3224     3226       +2     
+ Misses         627      625       -2     
  Partials       110      110              
Flag Coverage Δ
unittests 81.44% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmselfsup/evaluation/functional/__init__.py 66.66% <0.00%> (-33.34%) ⬇️
...fsup/evaluation/functional/res_layer_extra_norm.py 47.36% <0.00%> (+21.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As inline comments

Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyixiao18 fangyixiao18 merged commit 51a131d into open-mmlab:dev-1.x Oct 31, 2022
@fangyixiao18 fangyixiao18 deleted the refine-configs branch November 2, 2022 02:28
fangyixiao18 added a commit that referenced this pull request Nov 3, 2022
* update ci workflow

* add test for config

* update configs

* update imagenet 1pct and 10pct

* update configs according to mmcls interface

* update link

* add copyright

* update ci

* update ci install command

* update data_preprocessor field

* fix value of mean, std and add comments

* remove redundant configs
fangyixiao18 added a commit that referenced this pull request Nov 3, 2022
* update ci workflow

* add test for config

* update configs

* update imagenet 1pct and 10pct

* update configs according to mmcls interface

* update link

* add copyright

* update ci

* update ci install command

* update data_preprocessor field

* fix value of mean, std and add comments

* remove redundant configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants