New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] support MaskFeat pre-training with video #678
Conversation
6d124b6
to
bc15eb2
Compare
Codecov ReportBase: 80.64% // Head: 80.64% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #678 +/- ##
===========================================
- Coverage 80.64% 80.64% -0.01%
===========================================
Files 141 141
Lines 5089 5124 +35
Branches 671 685 +14
===========================================
+ Hits 4104 4132 +28
- Misses 850 854 +4
- Partials 135 138 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -0,0 +1,102 @@ | |||
_base_ = 'mmselfsup::selfsup/_base_/default_runtime.py' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This config file seems redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified this config for 8 gpus, inherited from the other one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM(please update the doc with usage of train.py/test.py)
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Prerequisite PR: open-mmlab/mmaction2#2186
Support MaskFeat video pretraining in
projects
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: