Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engine.md and evaluation.md in zh_cn #725

Merged
merged 5 commits into from Mar 28, 2023
Merged

Add engine.md and evaluation.md in zh_cn #725

merged 5 commits into from Mar 28, 2023

Conversation

xuan07472
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Translate engine.md and evaluation.md in docs/en

Modification

Add engine.md and evaluation.md in docs/zh_cn

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

docs/zh_cn/advanced_guides/engine.md Outdated Show resolved Hide resolved
docs/zh_cn/advanced_guides/engine.md Outdated Show resolved Hide resolved
docs/zh_cn/advanced_guides/engine.md Outdated Show resolved Hide resolved
docs/zh_cn/advanced_guides/engine.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@xuan07472 xuan07472 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accidentally merged the 1.x branch, but found it just has this extra PR: open-mmlab#723, do I need to fall back to the previous version?

@fangyixiao18
Copy link
Collaborator

I accidentally merged the 1.x branch, but found it just has this extra PR: open-mmlab#723, do I need to fall back to the previous version?

yes, please fall back to your previous version

@xuan07472
Copy link
Contributor Author

I accidentally merged the 1.x branch, but found it just has this extra PR: open-mmlab#723, do I need to fall back to the previous version?

yes, please fall back to your previous version

Ok, I have returned the version and resubmitted the revision. Please check it.

docs/en/advanced_guides/engine.md Outdated Show resolved Hide resolved
docs/zh_cn/advanced_guides/engine.md Outdated Show resolved Hide resolved
Co-authored-by: Yixiao Fang <36138628+fangyixiao18@users.noreply.github.com>
@fangyixiao18 fangyixiao18 merged commit 81894e3 into open-mmlab:dev-1.x Mar 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants