Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add uname-like info on Windows #208

Closed
bgoglin opened this issue Aug 11, 2016 · 0 comments
Closed

add uname-like info on Windows #208

bgoglin opened this issue Aug 11, 2016 · 0 comments
Labels
enhancement good first issue help wanted Windows
Milestone
Future

Comments

@bgoglin
Copy link
Contributor

bgoglin commented Aug 11, 2016

lstopo uses GetComputerName() to display the hostname, but we don't actually set a HostName info attribute in the root object on windows.
topology-windows.c already calls hwloc_add_uname_info() in misc.c but that one does nothing on Windows. We should use GetComputerName() and GetSystemInfo() to set uname-like variables.
@bgoglin bgoglin added this to the Future milestone Aug 11, 2016
@bgoglin bgoglin mentioned this issue Apr 13, 2019
Open
bgoglin added a commit to bgoglin/hwloc that referenced this issue Oct 16, 2020
@bgoglin
windows: emulate uname
6bc1d49 
Use GetVersionEx() to get version numbers
(it's deprecated but it works and it's more convenient than IsWindows10OrGreater() etc)

Use GetComputerName() like we did in lstopo when missing a hostname.

Use GetNativeSystemInfo() to get the architecture (and make it  Unix-like string).

Add a WindowsBuildEnvironment info attr for cygwin/mingw.

Closes open-mpi#208

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
bgoglin added a commit to bgoglin/hwloc that referenced this issue Oct 16, 2020
@bgoglin
windows: emulate uname
8b2245e 
Use GetVersionEx() to get version numbers
(it's deprecated but it works and it's more convenient than IsWindows10OrGreater() etc)

Use GetComputerName() like we did in lstopo when missing a hostname.

Use GetNativeSystemInfo() to get the architecture (and make it a Unix-like string).

Add a WindowsBuildEnvironment info attr for cygwin/mingw.

Closes open-mpi#208

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
bgoglin added a commit to bgoglin/hwloc that referenced this issue Oct 16, 2020
@bgoglin
windows: emulate uname
0e90fee 
Use GetVersionEx() to get version numbers
(it's deprecated but it works and it's more convenient than IsWindows10OrGreater() etc)

Use GetComputerName() like we did in lstopo when missing a hostname.

Use GetNativeSystemInfo() to get the architecture (and make it a Unix-like string).

Add a WindowsBuildEnvironment info attr for cygwin/mingw.

Closes open-mpi#208

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted Windows
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@bgoglin