Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon theming #466

Closed
arcolinuxz opened this issue May 18, 2021 · 3 comments
Closed

Icon theming #466

arcolinuxz opened this issue May 18, 2021 · 3 comments

Comments

@arcolinuxz
Copy link

arcolinuxz commented May 18, 2021

Can you add the line

Icon=hwloc

to your .desktop file in /usr/share/applications

It makes your application themable.

image

@bgoglin
Copy link
Contributor

bgoglin commented May 18, 2021

Hello
Aren't we supposed to distribute a hwloc.foo icon then? Or would the behavior be similar to currently but themes would be able to specify/override a custom icon for lstopo?
Brice

@arcolinuxz
Copy link
Author

arcolinuxz commented May 18, 2021

You can supply your own icon

Most of the time developers put their icons in /usr/share/icons/hicolor

It can be a png or a svg

but

In the .desktop file (in /usr/share/applications) you do not use paths or extensions

so just

Icon=hwloc

Linux will then search for any and all icons with that name - png or svg
When the users chooses the icon theme - Linux will look in that folder for the name "hwloc".

An icon is not 'necessary' as it depends on the icon theme the user selected but if the icon is missing in that theme most icon themes go to hicolor folder/theme as its dependency. So then it will find an icon.

I hope it is clear.
Ask and I will assist.

bgoglin added a commit that referenced this issue May 19, 2021
Even if we don't have an icon yet, it'll make the lstopo application themable.

Closes #466

Signed-off-by: Brice Goglin <Brice.Goglin@inria.fr>
(cherry picked from commit 8243068)
@bgoglin
Copy link
Contributor

bgoglin commented May 19, 2021

Thanks for the explanation, I applied this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants