Skip to content
This repository has been archived by the owner on Sep 30, 2022. It is now read-only.

Allow NULL arrays for empty datatypes. #1122

Merged
merged 1 commit into from Jul 18, 2016

Conversation

jsquyres
Copy link
Member

@jsquyres jsquyres commented May 2, 2016

When building an empty datatype (aka. size = 0) because the count of
included datatypes is 0, be less strict on what the arguments are
(allow NULL pointers).

(cherry picked from commit open-mpi/ompi@6e6ed62)

@bosilca Please review. Straightforward cherry-pick from master.

@hppritcha I just PR'ed this to v1.10.3, and it apparently solves a user issue (reported by @wkliao in open-mpi/ompi#1611). I don't have strong feelings as to whether this is in v2.0.0 or v2.0.1, other than the fact that it fixes a user-reported error. Opinions?

When building an empty datatype (aka. size = 0) because the count of
included datatypes is 0, be less strict on what the arguments are
(allow NULL pointers).

(cherry picked from commit open-mpi/ompi@6e6ed62)
@jsquyres jsquyres added the bug label May 2, 2016
@jsquyres jsquyres added this to the v2.0.0 milestone May 2, 2016
@mellanox-github
Copy link

Test PASSed.
See http://bgate.mellanox.com/jenkins/job/gh-ompi-release-pr/1583/ for details.

@hppritcha
Copy link
Member

2.0.1

Am Montag, 2. Mai 2016 schrieb Jeff Squyres :

When building an empty datatype (aka. size = 0) because the count of
included datatypes is 0, be less strict on what the arguments are
(allow NULL pointers).

(cherry picked from commit open-mpi/ompi@6e6ed62
open-mpi/ompi@6e6ed62
)

@bosilca https://github.com/bosilca Please review. Straightforward
cherry-pick from master.

@hppritcha https://github.com/hppritcha I just PR'ed this to v1.10.3,
and it apparently solves a user issue (reported by @wkliao
https://github.com/wkliao in open-mpi/ompi#1611
open-mpi/ompi#1611). I don't have strong
feelings as to whether this is in v2.0.0 or v2.0.1, other than the fact

that it fixes a user-reported error. Opinions?

You can view, comment on, or merge this pull request online at:

#1122
Commit Summary

  • Allow NULL arrays for empty datatypes.

File Changes

Patch Links:


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1122

@jsquyres jsquyres modified the milestones: v2.0.1, v2.0.0 May 2, 2016
@bosilca
Copy link
Member

bosilca commented May 2, 2016

👍

@jsquyres
Copy link
Member Author

bot:retest

1 similar comment
@jsquyres
Copy link
Member Author

bot:retest

@jsquyres jsquyres merged commit 191018b into open-mpi:v2.x Jul 18, 2016
@jsquyres jsquyres deleted the pr/v2.0.0/datatype-zero-length branch July 18, 2016 19:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants