Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ess/singleton: expects 4 PMIX_* environment variables or more
- Loading branch information
1 parent
696121c
commit a1e8e58
Showing
1 changed file
with
7 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1e8e58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhc54 can you please double check this ?
current internal pmix has now 5 PMIX_* environment variables.
that being said, i did not simply replace
if (4 != opal_argv_count(argv))
withif (5 != opal_argv_count(argv))
andfor (i=0; i < 4; i++)
withfor (i=0; i < 5; i++)
since (older) external pmix might still use 4 PMIX_* environment variables.a1e8e58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest just dropping the test altogether - just push everything we get into the environment.
a1e8e58
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, will do from now