Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSM2 MTL uses same help filename as PSM MTL #1018

Closed
jsquyres opened this issue Oct 13, 2015 · 4 comments
Closed

PSM2 MTL uses same help filename as PSM MTL #1018

jsquyres opened this issue Oct 13, 2015 · 4 comments
Labels
Milestone

Comments

@jsquyres
Copy link
Member

Both components have a help-mtl-psm.txt.

The PSM2 MTL should rename its helpfile to be help-mtl-psm2.txt.

@matcabral Can you fix?

@jsquyres jsquyres added the bug label Oct 13, 2015
@jsquyres jsquyres added this to the Open MPI v2.0.0 milestone Oct 13, 2015
@jsquyres
Copy link
Member Author

Additionally, the help message checker turned up this (which may be just another symptom of the duplicate filename):

*** WARNING: Possibly unused help topic
  Help file: ./mca/mtl/psm2/help-mtl-psm.txt
  Help topic: debug level
*** WARNING: Possibly unused help topic
  Help file: ./mca/mtl/psm2/help-mtl-psm.txt
  Help topic: path query mechanism unknown

@matcabral
Copy link
Contributor

Hi Jeff,

Intel PSM team renamed all the externally exposed symbols in psm2.so to address the issue discussed here: http://www.open-mpi.org/community/lists/devel/2015/09/17919.php . To support that change I updated Open MPI PSM2 MTL, including the change you suggest above. I’m in the process of testing the changes before submitting the PR. However, I found things failing. Once I clear the findings I’ll post it.

Thanks,

@jsquyres
Copy link
Member Author

Sounds good. Thanks!

@jsquyres
Copy link
Member Author

@matcabral BTW, pro tip: if you include "Fixes #1018" in the commit message where you fix this help file issue, it'll automatically close this issue when your PR with that commit is merged to master. See https://github.com/open-mpi/ompi/wiki/GithubCommitMessages for a little more detail.

matcabral added a commit that referenced this issue Oct 28, 2015
Updated psm2 mtl with new externally exposed symbols of psm2.so 
Fixes #1018
Fixes #1021
jsquyres pushed a commit to jsquyres/ompi that referenced this issue Aug 23, 2016
…tr_types

ompi/win: use type int* for MPI_WIN_DISP_UNIT, MPI_WIN_CREATE_FLAVOR …
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants