Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.0.0rc2: Regression in MPI_File_get_info() #1630

Closed
dalcinl opened this issue May 4, 2016 · 0 comments
Closed

2.0.0rc2: Regression in MPI_File_get_info() #1630

dalcinl opened this issue May 4, 2016 · 0 comments
Assignees
@edgargabriel
Labels
bug
Milestone
v2.0.0

Comments

@dalcinl
Copy link
Contributor

dalcinl commented May 4, 2016

After creating a file passing null info handle, quering for the info returns a null info handle. Previous releases returned a non null info handle. The wording in the MPI-3 standard seems to imply that the call should return a new (I interpret that as non-null) info handle.

from mpi4py import MPI
comm = MPI.COMM_SELF
mode = MPI.MODE_RDWR | MPI.MODE_CREATE
info = MPI.INFO_NULL
fh = MPI.File.Open(comm, "/tmp/datafile", mode, info)
assert fh.Get_info() != MPI.INFO_NULL
$ python test-ompi-1.py 
Traceback (most recent call last):
  File "test-ompi-1.py", line 6, in <module>
    assert fh.Get_info() != MPI.INFO_NULL
AssertionError
@jsquyres jsquyres added the bug label May 5, 2016
@hppritcha hppritcha added this to the v2.0.0 milestone May 5, 2016
jsquyres added a commit to jsquyres/ompi that referenced this issue May 5, 2016
@jsquyres
ompio: always return valid info from FILE_GET_INFO
4a45888 
MPI-3.1 says that even if no info keys are set on the file, we need to
return a new, empty info.

Thanks to Lisandro Dalcin for identifying the issue.

Fixes open-mpi#1630

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
@jsquyres jsquyres mentioned this issue May 5, 2016
Merged
jsquyres added a commit to jsquyres/ompi that referenced this issue May 5, 2016
@jsquyres
ompio: always return valid info from FILE_GET_INFO
f167be1 
MPI-3.1 says that even if no info keys are set on the file, we need to
return a new, empty info.

Thanks to Lisandro Dalcin for identifying the issue.

Fixes open-mpi#1630

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
jsquyres added a commit to jsquyres/ompi-release that referenced this issue May 5, 2016
@jsquyres
ompio: always return valid info from FILE_GET_INFO
2e5429c 
MPI-3.1 says that even if no info keys are set on the file, we need to
return a new, empty info.

Thanks to Lisandro Dalcin for identifying the issue.

Fixes open-mpi/ompi#1630

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>

(cherry picked from commit open-mpi/ompi@f167be1)
@jsquyres jsquyres mentioned this issue May 5, 2016
Merged
bosilca pushed a commit to bosilca/ompi that referenced this issue Oct 3, 2016
@jsquyres @bosilca
ompio: always return valid info from FILE_GET_INFO
1c1ab24 
MPI-3.1 says that even if no info keys are set on the file, we need to
return a new, empty info.

Thanks to Lisandro Dalcin for identifying the issue.

Fixes open-mpi#1630

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edgargabriel edgargabriel

Labels
bug
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
4 participants
@dalcinl @jsquyres @hppritcha @edgargabriel