java: catch exceptions if we fail to load mpi_java #10697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a step along the way to retaining ease of use with prrte for java apps |
kawashima-fj
requested changes
Aug 21, 2022
There was a problem hiding this comment.
@hppritcha Just a question. How the behavior is changed? Only the messsage change? Exiting cleanly?
ompi/mpi/java/java/MPI.java
Outdated
Comment on lines
208
to
210
| { | ||
| System.loadLibrary("mpi_java") ; | ||
| } | ||
| catch (UnsatisfiedLinkError e) | ||
| { | ||
| System.err.println("mpi java lib failed to load" + e + "\n") ; | ||
| System.exit(1) ; | ||
| } |
There was a problem hiding this comment.
Please use tabs instead of spaces for indentation. Other Java codes in OMPI use tabs.
ompi/mpi/java/java/MPI.java
Outdated
| } | ||
| catch (UnsatisfiedLinkError e) | ||
| { | ||
| System.err.println("mpi java lib failed to load" + e + "\n") ; |
There was a problem hiding this comment.
Please insert a space of something before the Java exception message.
Suggested change
| System.err.println("mpi java lib failed to load" + e + "\n") ; | |
| System.err.println("mpi java lib failed to load: " + e + "\n") ; |
hppritcha
force-pushed
the
java_better_loadlibrary
branch
from
bc3bac9
to
4fa49cb
Compare
|
@kawashima-fj check now, hopefully i got the tabs right! |
ompi/mpi/java/java/MPI.java
Outdated
| try | ||
| { | ||
| System.loadLibrary("mpi_java") ; | ||
| } |
There was a problem hiding this comment.
The line 210 still has space-indentation.
There was a problem hiding this comment.
okay i think that fixed it.
library. Signed-off-by: Howard Pritchard <howardp@lanl.gov>
hppritcha
force-pushed
the
java_better_loadlibrary
branch
from
4fa49cb
to
54042fc
Compare
|
@kawashima-fj i think line 210 is fixed now |
kawashima-fj
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
library.
Signed-off-by: Howard Pritchard howardp@lanl.gov