Fix typo in liboshmem name

[opoplawski]

No description provided.

[jsquyres]

@miked-mellanox @jladd-mlnx This looks like a trivial / obvious fix.

My question is: how did this work at all with this typo? Are we missing something obvious here?

[opoplawski]

I think all it affected was the determination of whether the shared library was available. Actual link flags are in the libs* -l settings.

[jsquyres]

But it still should have always complained that the library wasn't there, right?

[opoplawski]

Possibly, but at the moment the logic in opal_wrapper.c is:

            if (have_dyn_lib) {
                use_static_libs = false;
            } else {
                use_static_libs = true;
            }

So it blindly uses the static link line if the shared library isn't found. This is how I found the issue.

[jsquyres]

Ah, ok. That makes sense.

Even though it looks trivial/correct to me, I'd still like @miked-mellanox and @jladd-mlnx to ack this before we accept it (it's their code, after all).

[mike-dubman]

looks right.

[jladd-mlnx]

Ack. Good catch.

[jsquyres]

Yikes; looks like I pushed the wrong button a few days ago ("close and comment" vs. "comment").

Ok, Mike and Josh like it, so let's do it.

[opoplawski]

It would be nice to have this ported back to 1.8.X as well.

[rhc54]

Done - thx for pointing it out