Topic/hcoll config #796
Topic/hcoll config #796
Conversation
|
@miked-mellanox could you please review this ? |
| @@ -25,20 +25,17 @@ AC_DEFUN([OMPI_CHECK_FCA],[ | |||
| OPAL_CHECK_WITHDIR([fca], [$with_fca], [lib/libfca.so]) | |||
|
|
|||
| AS_IF([test "$with_fca" != "no"], | |||
| [AS_IF([test ! -z "$with_fca" && test "$with_fca" != "yes"], | |||
| [ompi_check_fca_libs=fca | |||
| AS_IF([test ! -z "$with_fca" && test "$with_fca" != "yes"], | |||
| [ompi_check_fca_dir=$with_fca | |||
There was a problem hiding this comment.
$with_fca might equal no at this point (if the user specified --without-fca).
|
@jsquyres got it, will do |
ggouaillardet
force-pushed
the
topic/hcoll_config
branch
2 times, most recently
from
d976245
to
4fbf431
Compare
|
@jsquyres i updated this PR and made 3 for the ompi-release branches |
|
👍 |
| @@ -25,41 +25,37 @@ AC_DEFUN([OMPI_CHECK_FCA],[ | |||
| OPAL_CHECK_WITHDIR([fca], [$with_fca], [lib/libfca.so]) | |||
There was a problem hiding this comment.
The help string is inaccurate -- it says it looks for libraries in DIR, but it really looks in DIR/lib (and headers in DIR/include). Can you fix that up as part of this PR, too? (sorry!)
There was a problem hiding this comment.
i am doing that right now
i also fixed the same inaccurate string in hcoll, mxm (and knem too)
|
I can't test this, but I think it looks ok...? (other than the inaccurate help message) @bureddy did you test this patch? |
|
@jsquyres , Yes, I tested v1.8 patch with options --with-hcoll, --with-hcoll=yes, --with-hcoll=no, --with-hcoll=< hcoll_install > |
|
Cool. Can you test v1.10 and v2.x, too? Feel free the thumbs-up each of the PRs after you test them. Thanks! |
* do not add -I/.../include/hcoll -I /.../include/hcoll/api to CPPFLAGS * allow configure --with-hcoll * search hcoll libs in both DIR/lib and DIR/lib64 * fix the description of the --with-hcoll option
* do not add -I/.../include/fca -I /.../include/fca_core to CPPFLAGS * allow configure --with-fca * search fca libs in both DIR/lib and DIR/lib64 * fix the description of the --with-fca option
* search mxm libs in both DIR/lib and DIR/lib64 * fix the description of the --with-mxm option
ggouaillardet
force-pushed
the
topic/hcoll_config
branch
2 times, most recently
from
7383298
to
288e13b
Compare
ggouaillardet
force-pushed
the
topic/hcoll_config
branch
from
063ba38
to
6b2fe91
Compare
|
i fixed the messages and did some cleanup, |
|
One last comment: didn't a user bring this to our attention on the mailing list? If so, it would be good to cite that user's name in the commit message (as a way of saying "thank you!"). E.g., "Thanks to Joe Smith for bringing this issue to our attention." |
configury: fix hcoll, fca and mxm detection and revamp yalla Makefile.am Thanks to David Shrader and Ake Sandgren for bringing this issue to our attention
Silence libevent reentrant warning when using openib except for debug builds
No description provided.