Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the resource_to_telemetry_conversion to true in amp config.yaml files #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vasireddy99
Copy link

This PR will add dimensions/tags and more detailed information to AMP metrics which helps to identify the metrics using cluster_name, task_id

Modified the following ecs-amp config files by enabling the resource_to_telemetry_conversion to true

Paths to config files
config/ecs/ecs-amp.yaml
config/ecs/ecs-amp-xray.yaml
config/ecs/ecs-amp-xray-prometheus.yaml
config/ecs/ecs-amp-prometheus.yaml

Copy link

@aateeqi aateeqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, i'm wondering, do we need to update the docs for awsprometheusremotewrite upstream as well?

@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale label Dec 12, 2021
@github-actions github-actions bot removed the stale label Jul 31, 2022
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants