Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CircleCI workflows to GitHub Actions (2/3) #7

Closed
wants to merge 1 commit into from

Conversation

AzfaarQureshi
Copy link

@AzfaarQureshi AzfaarQureshi commented Oct 7, 2020

What this PR does

This is PR 2/3 of migrating Cortex's CI from CircleCI to GitHub Actions:

Part 1/3

  • create test-build-deploy workflow under .github/workflows
  • add readme
  • adding the 3 base jobs
    • lint
    • test
    • build
  • these jobs are run async and share no dependencies with each other
  • workflow is run when a commit is pushed to master or when any PR is opened. However CD jobs will only run on the master branch and will be skipped otherwise
  • all jobs in following PRs are dependant on one or more of these jobs finishing

Part 2/3 👈

  • adding jobs dependant on build
    • integration
    • integration-config-db
  • This PR completes the CI portion of migration. The following PR will finish the remaining CD portion of the migration

Part 3/3

  • This PR completes the migration from CircleCI to GitHub Actions
    • deploy_website is dependant on build, test
    • deploy is dependant on build, test, lint, integration, integration-config-db
  • CD jobs will only run on the master branch and will be otherwise skipped

Which issue(s) this PR fixes:

fixes cortexproject#3274

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@AzfaarQureshi AzfaarQureshi changed the title Added integration and integration-configs-db jobs Migrate CircleCI workflows to GitHub Actions (2/3) Oct 7, 2020
@shovnik shovnik force-pushed the gha-migration-1 branch 2 times, most recently from d383cf7 to 19f90c4 Compare October 8, 2020 17:33
@AzfaarQureshi AzfaarQureshi force-pushed the gha-migration-1 branch 3 times, most recently from df057f0 to f96681c Compare October 8, 2020 18:22
@AzfaarQureshi AzfaarQureshi force-pushed the gha-migration-2 branch 2 times, most recently from dde9b8e to f2a731c Compare October 8, 2020 18:29
@AzfaarQureshi AzfaarQureshi changed the base branch from gha-migration-1 to master October 13, 2020 14:59
Copy link

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm #shipit

…rkflow

Signed-off-by: Azfaar Qureshi <azfaarq@amazon.com>
Signed-off-by: Shovnik Bhattacharya <shovnik@amazon.com>

adding table to README and removing vestigial lines from workflow

Signed-off-by: Azfaar Qureshi <azfaarq@amazon.com>

Added integration and integration-configs-db jobs

Signed-off-by: Azfaar Qureshi <azfaarq@amazon.com>

reading from cortexproject

Signed-off-by: Azfaar Qureshi <azfaarq@amazon.com>

Made Step Naming Consistent

Signed-off-by: Shovnik Bhattacharya <shovnik@amazon.com>

read tag only if they exist on the push event

updating quay image

removing old README

changing to v2

Addressed changes requested in PR 1/3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants