Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus Remote Write Exporter (6/6) #14

Closed
wants to merge 19 commits into from
Closed

Prometheus Remote Write Exporter (6/6) #14

wants to merge 19 commits into from

Conversation

AzfaarQureshi
Copy link

@AzfaarQureshi AzfaarQureshi commented Nov 27, 2020 •
edited
Loading

Description

This is PR 2/6 of adding a Prometheus Remote Write Exporter in Python SDK and address Issue open-telemetry/opentelemetry-python#1302

Part 1/6

  • Adds class skeleton
  • Adds all function signatures

Part 2/6

  • Adds validation of exporter constructor commands
  • Add unit tests for validation

Part 3/6

  • Adds conversion methods from OTel metric types to Prometheus TimeSeries
  • Add unit tests for conversion

Part 4/6

  • Adds methods to export metrics to Remote Write endpoint
  • Add unit tests for exporting

Part 5/6

  • Add integration tests

👉 Part 6/6

  • Add README, Design Doc and other necessary documentation.
  • Add sample app running in dockerized environment

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Readme and documentation changes

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated
    cc- @shovnik, @alolita

AzfaarQureshi
AzfaarQureshi commented Nov 27, 2020
View reviewed changes
exporter/opentelemetry-exporter-prometheus-remote-write/setup.cfg
Comment on lines +42 to +43
opentelemetry-api >= 0.16b0
opentelemetry-sdk >= 0.16b0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after release 0.16b0 we can just install the api from PyPi

@AzfaarQureshi AzfaarQureshi force-pushed the 5-prometheus-remote-write branch 2 times, most recently from 80ec1a0 to 6052036 Compare November 28, 2020 23:36
@AzfaarQureshi AzfaarQureshi force-pushed the 5-prometheus-remote-write branch 4 times, most recently from 59e37ab to 36944fb Compare November 29, 2020 03:59
@AzfaarQureshi AzfaarQureshi force-pushed the 5-prometheus-remote-write branch 3 times, most recently from 6a18319 to 59b9aa0 Compare November 30, 2020 18:22
@AzfaarQureshi AzfaarQureshi force-pushed the 5-prometheus-remote-write branch 2 times, most recently from f13658b to d8ecbdc Compare November 30, 2020 20:24
@AzfaarQureshi AzfaarQureshi self-assigned this Dec 1, 2020
alolita
alolita approved these changes Dec 1, 2020
View reviewed changes
Copy link

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AzfaarQureshi AzfaarQureshi force-pushed the 5-prometheus-remote-write branch 4 times, most recently from cdc4bb3 to d5d83d4 Compare December 1, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alolita alolita alolita approved these changes

@shovnik shovnik shovnik approved these changes

Assignees

@AzfaarQureshi AzfaarQureshi

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@AzfaarQureshi @alolita @shovnik