Add metrics renaming changes to contrib #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzfaarQureshi
force-pushed
the
add-metrics-renaming-changes-to-contrib
branch
from
8e41278
to
90aff44
Compare
AzfaarQureshi
commented
Nov 19, 2020
| @@ -6,7 +6,7 @@ on: | |||
| - 'release/*' | |||
| pull_request: | |||
| env: | |||
| CORE_REPO_SHA: 47483865854c7adae7455f8441dab7f814f4ce2a | |||
| CORE_REPO_SHA: 3b813eb9921e709538dd1b07fa7a5f93600fbec1 | |||
There was a problem hiding this comment.
The SHA needs to be updated every time in the contrib repo because it runs tests using the latest version of core
AzfaarQureshi
force-pushed
the
add-metrics-renaming-changes-to-contrib
branch
4 times, most recently
from
1eb3f68
to
4aaa80c
Compare
AzfaarQureshi
force-pushed
the
add-metrics-renaming-changes-to-contrib
branch
from
4aaa80c
to
23de712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the corresponding renaming changes from otel-python open-telemetry/opentelemetry-python#1372 in the contrib to fix failing tests as noted here: open-telemetry/opentelemetry-python#1372 (comment)