Feature/side 1189 fix dependabot security issues #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-dependabot-security-issues
bbrewer-oliveai
requested review from
BillyMurrayOlive,
richseviora,
BrettMugglinOlive,
iangallOlive,
JonBernardOlive and
scottkipferOlive
iangallOlive
approved these changes
Jan 12, 2021
|
Thanks for taking this over and resolving the issues I had. A couple interesting things:
|
BrettMugglinOlive
approved these changes
Jan 12, 2021
richseviora
approved these changes
Jan 12, 2021
…at involve a bit of deliberation to fix
bbrewer-oliveai
force-pushed
the
feature/SIDE-1189-fix-dependabot-security-issues
branch
from
031fb02
to
221c89f
Compare
bbrewer-oliveai
force-pushed
the
feature/SIDE-1189-fix-dependabot-security-issues
branch
from
221c89f
to
2d8216e
Compare
bbrewer-oliveai
deleted the
feature/SIDE-1189-fix-dependabot-security-issues
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, this doesn't quite get highlight.js bumped b/c through a long chain of dependencies
grpc_tools_node_protoc_tsstill wants the deprecated version of it.