add validator upload file #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param string $folderId | ||
| * | ||
| * @return MediaInterface | ||
| */ | ||
| public function createMediaFromUploadedFile(UploadedFile $uploadedFile, $filename, $folderId); | ||
| public function createMediaFromUploadedFile(UploadedFile $uploadedFile, $folderId); |
There was a problem hiding this comment.
@alavieille : maybe introduce a new function and tag the other as deprecated ?
|
@ngilain pr upadted |
| @@ -120,27 +121,28 @@ public function uploadAction($folderId, Request $request) | |||
| $uploadedFile = $request->files->get('file'); | |||
| $saveMediaManager = $this->get('open_orchestra_media_admin.manager.save_media'); | |||
|
|
|||
| if ($uploadedFile && $filename = $saveMediaManager->getFilenameFromChunks($uploadedFile)) { | |||
| if ($uploadedFile && $uploadedFile = $saveMediaManager->getFilenameFromChunks($uploadedFile)) { | |||
There was a problem hiding this comment.
@alavieille : you need to change the method name if it's now returning an UplodadFile instead of string. Something like getFileFromChunks ?
|
@ngilain pr updated |
|
👍 |
alavieille
force-pushed
the
add_validator_upload_file
branch
from
148f343
to
ab635cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[OO-FEATURE] Add possibility to validate a media before upload
[OO-DEPRECATED] SaveMediaManager::isFileAllowed is deprecated and will remove in 2.0
[OO-DEPRECATED] SaveMediaManager::createMediaFromUploadedFile is deprecated and will remove in 2.0 use initializeMediaFromUploadedFile
[OO-DEPRECATED] SaveMediaManager::getFilenameFromChunks is deprecated and will remove in 2.0 use getFileFromChunks
open-orchestra/open-orchestra-media-bundle#234
open-orchestra/open-orchestra-docs#231