Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aacar endsIn fails to be generated correctly #208

Closed
tgbugs opened this issue Aug 18, 2022 · 4 comments
Closed

aacar endsIn fails to be generated correctly #208

tgbugs opened this issue Aug 18, 2022 · 4 comments

Comments

@tgbugs
Copy link
Contributor

tgbugs commented Aug 18, 2022

This bug may already have been fixed.

In aacar https://github.com/open-physiology/apinatomy-models/blob/410289fb2666330cbc5cd4448c58a06922ec6525/models/ard-arm-cardiac/source/ard-arm-cardiac.json

generation for ac-ven-epi_9 produces lnk_1 with a correct endsIn
whereas for
ac-vent-epi-term-6 and ac-atrial-epi-term-6 folllowing the same pattern fails to generate lnk_1 with endsIn

@tgbugs
Copy link
Contributor Author

tgbugs commented Aug 18, 2022

ac-vent-epi-term-6 and ac-atrial-epi-term-6 should endsIn A83

@tgbugs
Copy link
Contributor Author

tgbugs commented Aug 18, 2022

Confirming that this is still present on master.

@albatros13
Copy link
Member

There is no problem with endsIn, this is an error in the model - there is no lyph "74", there is lyph "A74". The validator warns you about it:
Failed to find chain level housing lyph
"74"
Failed to find chain level housing lyph
"74"
After replacing 74 to A74, both links have endsIn property filled

@albatros13
Copy link
Member

albatros13 commented Aug 29, 2022

Created the related issue on apinatomy-models project open-physiology/apinatomy-models#24
(Cannot fix myself as I do not know where the original Excel spreadsheet is, committing a copy leaves the risk that it will be overridden)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants