Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Result-list (#10, #11, #17, #234) #275

Merged
merged 164 commits into from
Feb 19, 2024
Merged

Result-list (#10, #11, #17, #234) #275

merged 164 commits into from
Feb 19, 2024

Conversation

SvenReissig
Copy link
Contributor

@SvenReissig SvenReissig commented Feb 15, 2024 •
edited by mbeckem
Loading

Issue: #11

ChristophMaskos and others added 30 commits December 1, 2023 13:26
@ChristophMaskos
init local storage package
083d302
@ChristophMaskos
prepare for pair-programming
95c225b
@senait8991
adjust selection position
6e993ee
@senait8991
add button for selection method + select form control
4e09708
@SvenReissig
Init Interfaces
6accef4
@SvenReissig
Init SelectionController and a TestSource
00e5198
@mirjaeisen
Use Fake Selection Source
81ea482
@senait8991
activate selection method only when component is visible
ab0e9e9
@SvenReissig
removed readonly status
305b234
@SvenReissig
added readonly status again
63ba74e
@mirjaeisen
Toggle Measurement and Selection tools so that only one is currently …
337a66d 
…active
@SvenReissig
added event handling for selection sources including test source impl…
e52c307 
…ementation
@senait8991
add useEffect hook for selection
dc4260a
@senait8991
add controller for selection interactions
cb4deb9
@ChristophMaskos
Dragbox and Tooltip has own controller
505a70f
@ChristophMaskos
add activeState
900c160
@senait8991
Merge remote-tracking branch 'origin/feature/selection-UI-and-basic-s…
26478dd 
…election' into feature/selection-UI-and-basic-selection

# Conflicts:
#	src/packages/selection/Selection.tsx
@senait8991
remove unused content
e5ffca6
@ChristophMaskos
tooltip Style like Measurement
3bd2f7b 
Crosshair-cursor for selection
@ChristophMaskos
Merge branch 'feature/selection-UI-and-basic-selection' of https://gi…
7a49d66 
…thub.com/open-pioneer/trails-openlayers-base-packages into feature/selection-UI-and-basic-selection
@SvenReissig
startet with controller tests
7efa7ad
@mirjaeisen
Start to use chakra react select instead of chakra select
10c629c
@mirjaeisen
Add size to container; adjust selection-import
284d043
@mirjaeisen
Add chakra react select to package.json
e74b675
@mirjaeisen
Add chakra react select dependency to pnpm-lock file
721db32
@mirjaeisen
Add react-icons to package.json, remove unused import
bfb1fd7
@mirjaeisen
Add README and CHANGELOG
b76b916
@mirjaeisen
Fix typos and make disabled react-select-option not selectable
bca1bf7
@ChristophMaskos
connect SelectionController.ts with Selection.tsx.
ed30494 
!Be aware of the infinite-Render-Loop with sources as dependency!
@SvenReissig
added status test and logic
d658cf9
mirjaeisen and others added 15 commits February 6, 2024 12:11
@mirjaeisen
Move result list metadata to layer-attributes and updated README
ddefd85
@SvenReissig
changed sorting icon focus look
8a243ab 
- added aria labels for sorting and select boxes
@SvenReissig
Merge remote-tracking branch 'origin/feature/result-list' into featur…
dcfb7b5 
…e/result-list
@panayot-nenov
clean up DataTable
3c6d313
@SvenReissig
removed tableWidth parameter
9659e26 
- refactored columnSizeVars to hook
@panayot-nenov
wip clean up
a24bfc2
@SvenReissig
refactored data table and components
330449e
@SvenReissig
more refactoring of data table and components
64fa0dd
@SvenReissig
Merge branch 'main' into feature/result-list
46766ac 
# Conflicts:
#	.changeset/light-boxes-hide.md
@SvenReissig
taken care of some todos + added width test
81cf91c
@SvenReissig
added useTableWith
41c531a
@SvenReissig
Merge branch 'main' into feature/result-list
0983b33
@SvenReissig
updated test-utils version
9508c71 
- added intl to tests and reverted optional intl
- refactored ColumnSorter to just be visible
- added header underline on focus
- changed error if no metadata
@SvenReissig
cleanup
9cac75e 
- sorting and accessibility adjustments
- updated README.md
- small things
@SvenReissig
Merge branch 'main' into feature/result-list
0f60c18 
# Conflicts:
#	src/samples/map-sample/ol-app/MapConfigProviderImpl.ts
@mbeckem
Review most changes and iron out some remaining issues
72efb5e 
- Add missing changeset entries for other packages
- Fix an issue in MapContainer when handling view padding
- Remove imports of internal modules from other packages
- Streamline css classes
- Rename `metadata` prop to `columns`
- Use `shouldWrapChildren` (to fix tooltips) and `closeOnClick={false}` in selection checkbox
- Use feature id as table row id (this also uses feature ids for row `key`s)
- Resizing: ensure double clicking the resizer restores original size (previously, the table would not resize the columns until another resize was done)
- Resizing: change rendering a bit (doubles as border)
- Resizing: block click events during resize. Previously, releasing the mouse above the column header would trigger sorting.
- Resizing: use resize cursor on the whole table when resizing is active
- Prepare mapId prop (currently unused) for future map interactions (zoom etc.)
- Add doc comments on exported interfaces
- Sample app: Integrate the result list via viewPadding. This re-centers the view when the list is shown / hidden.
@mbeckem
Fix import of a private module of another package
906a840
@mbeckem
Merge remote-tracking branch 'origin/main' into feature/result-list
98e1128
@ChristophMaskos ChristophMaskos mentioned this pull request Feb 19, 2024
Merged
@mbeckem mbeckem mentioned this pull request Feb 19, 2024
Closed
@mbeckem mbeckem merged commit 13ea342 into main Feb 19, 2024
6 checks passed
@mbeckem mbeckem deleted the feature/result-list branch February 19, 2024 14:38
mbeckem added a commit to open-pioneer/trails-core-packages that referenced this pull request Feb 27, 2024
@SvenReissig @ChristophMaskos
@senait8991 @mirjaeisen @mbeckem @mathe05 @panayot-nenov @bierett
Implement result list component (open-pioneer/trails-openlayers-base-…
82bf857 
…packages#11, open-pioneer/trails-openlayers-base-packages#275)

Co-authored-by: Christoph Maskos <Christoph.Maskos@it.nrw.de>
Co-authored-by: Senait <s.alema@conterra.de>
Co-authored-by: m.eisenblaetter <m.eisenblaetter@conterra.de>
Co-authored-by: Michael Beckemeyer <m.beckemeyer@conterra.de>
Co-authored-by: Matheisen, Alexander <alexander.matheisen@it.nrw.de>
Co-authored-by: Panayot Nenov <Panayot.Nenov@it.nrw.de>
Co-authored-by: panayot-nenov <32521582+panayot-nenov@users.noreply.github.com>
Co-authored-by: Bierett, Danilo <danilo.bierett@it.nrw.de>
mbeckem added a commit to open-pioneer/trails-core-packages that referenced this pull request Feb 27, 2024
@SvenReissig @ChristophMaskos
@senait8991 @mirjaeisen @mbeckem @mathe05 @panayot-nenov @bierett
Implement result list component (open-pioneer/trails-openlayers-base-…
e225859 
…packages#11, open-pioneer/trails-openlayers-base-packages#275)

Co-authored-by: Christoph Maskos <Christoph.Maskos@it.nrw.de>
Co-authored-by: Senait <s.alema@conterra.de>
Co-authored-by: m.eisenblaetter <m.eisenblaetter@conterra.de>
Co-authored-by: Michael Beckemeyer <m.beckemeyer@conterra.de>
Co-authored-by: Matheisen, Alexander <alexander.matheisen@it.nrw.de>
Co-authored-by: Panayot Nenov <Panayot.Nenov@it.nrw.de>
Co-authored-by: panayot-nenov <32521582+panayot-nenov@users.noreply.github.com>
Co-authored-by: Bierett, Danilo <danilo.bierett@it.nrw.de>
mbeckem added a commit to open-pioneer/trails-core-packages that referenced this pull request May 23, 2024
@SvenReissig @ChristophMaskos
@senait8991 @mirjaeisen @mbeckem @mathe05 @panayot-nenov @bierett
Implement result list component (open-pioneer/trails-openlayers-base-…
83e1db3 
…packages#11, open-pioneer/trails-openlayers-base-packages#275)

Co-authored-by: Christoph Maskos <Christoph.Maskos@it.nrw.de>
Co-authored-by: Senait <s.alema@conterra.de>
Co-authored-by: m.eisenblaetter <m.eisenblaetter@conterra.de>
Co-authored-by: Michael Beckemeyer <m.beckemeyer@conterra.de>
Co-authored-by: Matheisen, Alexander <alexander.matheisen@it.nrw.de>
Co-authored-by: Panayot Nenov <Panayot.Nenov@it.nrw.de>
Co-authored-by: panayot-nenov <32521582+panayot-nenov@users.noreply.github.com>
Co-authored-by: Bierett, Danilo <danilo.bierett@it.nrw.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbeckem mbeckem mbeckem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SvenReissig @mbeckem @ChristophMaskos @senait8991 @mirjaeisen @mathe05 @panayot-nenov