Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade libraries to k8s 1.20. #31

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

willbeason
Copy link
Member

I have not been able to test this locally. Everything builds, but:

cert-controller$ make test
go test ./... -coverprofile cover.out
2021/02/09 07:37:55 failed to start the controlplane. retried 5 times: fork/exec /usr/local/kubebuilder/bin/etcd: exec format error
FAIL	github.com/open-policy-agent/cert-controller/pkg/rotator	0.138s
FAIL
make: *** [Makefile:7: test] Error 1

I haven't found any setup instructions on how to successfully run tests. I get the same issue when trying to run tests on HEAD.

Will Beason added 2 commits February 23, 2021 10:53
Signed-off-by: Will Beason <willbeason@google.com>
No code changes required.

Signed-off-by: Will Beason <willbeason@google.com>
@codecov-io
Copy link

Codecov Report

Merging #31 (83600a1) into master (4842e47) will increase coverage by 0.53%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   51.74%   52.27%   +0.53%     
==========================================
  Files           1        1              
  Lines         373      373              
==========================================
+ Hits          193      195       +2     
+ Misses        124      123       -1     
+ Partials       56       55       -1     
Flag Coverage Δ
unittests 52.27% <ø> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/rotator/rotator.go 52.27% <0.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4842e47...83600a1. Read the comment docs.

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@sozercan LGTY?

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we investigate if there are any roadblocks for vendoring in GK before merging?

@maxsmythe
Copy link
Contributor

I don't think it's necessary, we should upgrade Gatekeeper's dependencies regardless, and it seems selfish to block on 1 project without strong reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants