feat: upgrade to ORAS Go v2 #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the ORAS Go v1 dependency and upgrades to ORAS Go v2. The support for authentication via docker dependency was removed in ORAS Go v2 so parts of that needed to be replaced with cpuguy83/dockercfg[1]. Tests were expanded to include a TLS secured and basic auth protected registry. Signed-off-by: Zoran Regvart <zoran@regvart.com> [1] github.com/cpuguy83/dockercfg Signed-off-by: Zoran Regvart <zoran@regvart.com>
|
This looks awesome. Thanks @zregvart ! |
jpreese
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the ORAS Go v1 dependency and upgrades to ORAS Go v2. The support for authentication via docker dependency was removed in ORAS Go v2 so parts of that needed to be replaced with cpuguy83/dockercfg[1].
Tests were expanded to include a TLS secured and basic auth protected registry.
[1] github.com/cpuguy83/dockercfg