Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no policies found #794

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

boranx
Copy link
Member

@boranx boranx commented Mar 15, 2023

Fix: #558
Correlates: #785 and #769

Seems like no-policies-found was added as of https://github.com/open-policy-agent/conftest/blob/v0.22.0/output/standard.go
because it doesn't exist in https://github.com/open-policy-agent/conftest/blob/v0.21.0/output/standard.go
I'm not sure for what reason it was added here or due to which requirement but seems it's not considered for some of the users. Also in my tests, I didn't see any action on totalPolicies other than just printing info so discarded this

Thanks for the review in advance

Signed-off-by: boranx <boran.seref@gmail.com>
@boranx
Copy link
Member Author

boranx commented Mar 16, 2023

nvm, it was named differently, currentPolicies... but still there's no logic other than using log print, so maybe it was related to logger levels

Copy link
Member

@jalseth jalseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking the time to tackle this old issue.

@jalseth jalseth merged commit 96c44d3 into open-policy-agent:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library files output that no policies were found
2 participants