Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect regardless of port and loopback #806

Merged

Conversation

zregvart
Copy link
Contributor

When detecting OCI go-getter strings, the detector can look at any port number and any loopback interface address and consider it to be a local OCI registry.

When detecting OCI go-getter strings, the detector can look at any port
number and any loopback interface address and consider it to be a local
OCI registry.

Signed-off-by: Zoran Regvart <zoran@regvart.com>
Copy link
Member

@boranx boranx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice! also, +1 to transform those to regex
Thanks for the contribution

@boranx boranx merged commit 9a3dfe4 into open-policy-agent:master Mar 29, 2023
@zregvart zregvart deleted the pr/refine-oci-detect-local branch March 30, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants