Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use Bool instead of BoolP for three flags #847

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix: Use Bool instead of BoolP for three flags #847

merged 1 commit into from
Jul 26, 2023

Conversation

simonbaird
Copy link
Contributor

Since the shorthand name is empty, there's no need to use BoolP, so let's use Bool instead.

@simonbaird
fix: Use Bool instead of BoolP for three flags
44ea019 
Since the shorthand name is empty, there's no need to use BoolP, so
let's use Bool instead.

Signed-off-by: Simon Baird <sbaird@redhat.com>
@simonbaird simonbaird mentioned this pull request Jul 25, 2023
Merged
boranx
boranx approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@boranx boranx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, the shorthands didn't get added for those commands so far, and no request from the community in that direction either

Thanks for the correction

@boranx boranx merged commit 00f791b into open-policy-agent:master Jul 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boranx boranx boranx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonbaird @boranx