ci: Bump Go to 1.21.x #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpreese
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Change itself is fine, but I wonder if we should just define 1.21 instead of going as far as defining the patch. It would have parity with the go.mod and is less churn having to update the version as much.
Also of note, our go.mod is only 1.19 -- not necessarily a problem, but differs from what we have setup in CI
Always use the latest patch without needing to commit each new patch version to source. Signed-off-by: James Alseth <james@jalseth.me>
|
Using the latest patch is fine with me. I updated the commit. As far as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.