fix: Add tls flag to test command #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IcaroBichir
approved these changes
Jan 19, 2024
jalseth
requested changes
Jan 20, 2024
internal/commands/test.go
Outdated
| @@ -110,6 +110,9 @@ func NewTestCommand(ctx context.Context) *cobra.Command { | |||
| return fmt.Errorf("bind flag: %w", err) | |||
| } | |||
| } | |||
| if err := viper.BindPFlag("tls", cmd.Flags().Lookup("tls")); err != nil { | |||
There was a problem hiding this comment.
Instead of this, please add tls to the list above.
internal/commands/test.go
Outdated
| @@ -185,6 +188,7 @@ func NewTestCommand(ctx context.Context) *cobra.Command { | |||
| cmd.Flags().StringSliceP("data", "d", []string{}, "A list of paths from which data for the rego policies will be recursively loaded") | |||
|
|
|||
| cmd.Flags().StringSlice("proto-file-dirs", []string{}, "A list of directories containing Protocol Buffer definitions") | |||
| cmd.Flags().BoolP("tls", "s", true, "Use TLS to access the registry") | |||
There was a problem hiding this comment.
Please make this a Bool() call rather than BoolP. A single-letter alias of s for the tls flag does not make sense.
|
@oblogic7 If you would like this change to be in the next conftest release, please update the CL in the next couple of days. |
The pull command uses TLS by default by way of the value set for the `tls` flag. This change updates the `--update` flag on the test command to use TLS by default to align with the pull command. Signed-off-by: Matt Snyder <msnyder@repay.com>
|
Sorry for the delay. This should be ready now. |
jalseth
approved these changes
Feb 1, 2024
|
No problem, I just wanted to make sure this would make it in the release. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull command uses TLS by default by way of the default value set for the
tlsflag. This change updates the test command so--updateflag can use TLS by default to align with the pull command.