feat: Use ORAS credentials #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalseth
requested changes
Feb 15, 2024
The OCI go-getter support implemented in Conftest uses github.com/cpuguy83/dockercfg. With ORAS v2.4.0 the credentials support[1] was integrated in the oras-go. This makes for a good opportunity to switch to using that instead. In addition to using the supported credentials implementation this allows the use of Docker native credential helpers[2]. This implementation is also a bit more correct, as it avoids using the global default HTTP client, so mutations of it, e.g. when setting the user-agent, do not cause race issues. [1] https://github.com/oras-project/oras-credentials-go [2] https://docs.docker.com/engine/reference/commandline/login/#credential-helpers Signed-off-by: Zoran Regvart <zoran@regvart.com>
zregvart
force-pushed
the
pr/oras-credentials
branch
from
59e0466
to
e3c4420
Compare
jpreese
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OCI go-getter support implemented in Conftest uses github.com/cpuguy83/dockercfg. With ORAS v2.4.0 the credentials support[1] was integrated in the oras-go. This makes for a good opportunity to switch to using that instead. In addition to using the supported credentials implementation this allows the use of Docker native credential helpers[2].
This implementation is also a bit more correct, as it avoids using the global default HTTP client, so mutations of it, e.g. when setting the user-agent, do not cause race issues.
[1] https://github.com/oras-project/oras-credentials-go
[2] https://docs.docker.com/engine/reference/commandline/login/#credential-helpers