chore: Update setup-regal and golangci-lint actions to latest #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpreese
force-pushed
the
update-regal-action
branch
from
3a3da8a
to
2b338ba
Compare
Signed-off-by: John Reese <john@reese.dev>
jpreese
force-pushed
the
update-regal-action
branch
from
c3c5cc7
to
16887ad
Compare
jpreese
changed the title
jpreese
force-pushed
the
update-regal-action
branch
4 times, most recently
from
88b34e8
to
5f14a7d
Compare
Signed-off-by: John Reese <john@reese.dev>
jpreese
force-pushed
the
update-regal-action
branch
from
5f14a7d
to
536e7fe
Compare
jalseth
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
setup-regallinter to v1 and thegolangci-lintaction to v4 to help resolve thenodedeprecation warnings.falseto the install params onbats-core: I was seeing a ton of new warnings/errors that weren't there before (https://github.com/open-policy-agent/conftest/actions/runs/7901911540) when attempting to install these tools, but it doesn't look like we even use them.cache: falsetosetup-go: I was seeing a ton of file exists errors (https://github.com/open-policy-agent/conftest/actions/runs/7902189087) and it looks like people were reporting similar problems when caching was enabled ("File exists" errors when un-taring golangci-lint on upgrading to setup-go@v4 from setup-go@v3 golangci/golangci-lint-action#807 and Loads of "Error: /usr/bin/tar: ../../../go/pkg/mod/....: Cannot open: File exists golangci/golangci-lint-action#677). Resolution seems to be to disable the cache, albeit most agree it feels like a workaround. It does appear to resolve the issue, and build times don't seem to be impacted much if at all.Last
nodedeprecation warning to be resolved after bats-core/bats-action#2 is merged and our action is updated.