Set maximum constraint name length to 63

Signed-off-by: Max Smythe <smythe@google.com>
open-policy-agent · Jun 9, 2020 · b745ff7 · b745ff7
1 parent 5bae203
commit b745ff7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/constraint/pkg/client/crd_helpers.go b/constraint/pkg/client/crd_helpers.go
@@ -51,6 +51,14 @@ func (h *crdHelper) createSchema(templ *templates.ConstraintTemplate, target Mat
 	}
 	schema := &apiextensions.JSONSchemaProps{
 		Properties: map[string]apiextensions.JSONSchemaProps{
+			"metadata": apiextensions.JSONSchemaProps{
+				Properties: map[string]apiextensions.JSONSchemaProps{
+					"name": apiextensions.JSONSchemaProps{
+						Type:      "string",
+						MaxLength: func(i int64) *int64 { return &i }(63),
+					},
+				},
+			},
 			"spec": apiextensions.JSONSchemaProps{
 				Properties: props,
 			},

diff --git a/constraint/pkg/client/crd_helpers_test.go b/constraint/pkg/client/crd_helpers_test.go
@@ -104,7 +104,17 @@ func tProp(t string) apiextensions.JSONSchemaProps {
 
 func expectedSchema(pm propMap) *apiextensions.JSONSchemaProps {
 	pm["enforcementAction"] = apiextensions.JSONSchemaProps{Type: "string"}
-	p := prop(propMap{"spec": prop(pm)})
+	p := prop(
+		propMap{
+			"metadata": prop(propMap{
+				"name": apiextensions.JSONSchemaProps{
+					Type:      "string",
+					MaxLength: func(i int64) *int64 { return &i }(63),
+				},
+			}),
+			"spec": prop(pm),
+		},
+	)
 	return &p
 }