You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current tests in e2e_test.go all require the CT under test to reject all objects being reviewed. Instead, these tests should include cases specifying CTs that don't reject objects, or conditionally reject them. (Since these are E2E/integration tests and not unit tests, these paths should be covered)
This likely requires moving around how expectations are set - moving got from being specified inline in the test to denyAllCases (which needs to be renamed).
The text was updated successfully, but these errors were encountered:
Prerequisite: #150
See
constraint/pkg/client/e2e_test.go
.The current tests in e2e_test.go all require the CT under test to reject all objects being reviewed. Instead, these tests should include cases specifying CTs that don't reject objects, or conditionally reject them. (Since these are E2E/integration tests and not unit tests, these paths should be covered)
This likely requires moving around how expectations are set - moving
got
from being specified inline in the test todenyAllCases
(which needs to be renamed).The text was updated successfully, but these errors were encountered: