Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-deny-all tests to e2e_test.go #154

Closed
willbeason opened this issue Nov 15, 2021 · 1 comment
Closed

Add non-deny-all tests to e2e_test.go #154

willbeason opened this issue Nov 15, 2021 · 1 comment

Comments

@willbeason
Copy link
Member

Prerequisite: #150

See constraint/pkg/client/e2e_test.go.

The current tests in e2e_test.go all require the CT under test to reject all objects being reviewed. Instead, these tests should include cases specifying CTs that don't reject objects, or conditionally reject them. (Since these are E2E/integration tests and not unit tests, these paths should be covered)

This likely requires moving around how expectations are set - moving got from being specified inline in the test to denyAllCases (which needs to be renamed).

@willbeason willbeason added this to the Rego Environment Sharding milestone Nov 15, 2021
@willbeason
Copy link
Member Author

Duplicate of #154

@willbeason willbeason marked this as a duplicate of #154 Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant