Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #122

Merged

Conversation

willbeason
Copy link
Member

Use go get -u to upgrade dependencies.

Related to: open-policy-agent/gatekeeper#1335

The big thing here is upgrading opa from v0.24.0 to v0.29.4.

We are unable to safely upgrade to k8s 1.21 libraries until controller-runtime has a stable v0.9.0 release. That can be done later.

Remove installing opa v0.10 directly in the docker image as it seems vestigial and is no longer required.

Signed-off-by: Will Beason willbeason@google.com

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -19,18 +19,13 @@ spec:
- name: v1alpha1
schema:
openAPIV3Schema:
description: ConstraintTemplate is the Schema for the constrainttemplates
API
description: ConstraintTemplate is the Schema for the constrainttemplates API
Copy link
Member

@ritazh ritazh Jun 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julianKatz this is the same line break diff I'm seeing as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this is version skew against the version of controller-gen used. Did we dockerize that here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe kustomize

@ritazh
Copy link
Member

ritazh commented Jun 9, 2021

unit test failed:

package sigs.k8s.io/controller-tools/cmd/controller-gen@v0.5.0: can only use path@version syntax with 'go get'
make: *** [Makefile:34: gen-dependencies] Error 1

@willbeason
Copy link
Member Author

unit test failed:

package sigs.k8s.io/controller-tools/cmd/controller-gen@v0.5.0: can only use path@version syntax with 'go get'
make: *** [Makefile:34: gen-dependencies] Error 1

Ah, I found it.

@willbeason willbeason force-pushed the upgrade-dependencies branch 3 times, most recently from b75519f to ce2161d Compare June 10, 2021 15:53
@willbeason willbeason requested a review from ritazh July 13, 2021 14:57
@sozercan
Copy link
Member

@willbeason were you able to find the cause of unit test failure?

@willbeason
Copy link
Member Author

@willbeason were you able to find the cause of unit test failure?

Ah, I see. The GitHub Action was setting up Go 1.15 but we need 1.16. Fixed.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #122 (5a36034) into master (1dbe261) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files          35       35           
  Lines        2766     2766           
=======================================
  Hits         1167     1167           
  Misses       1234     1234           
  Partials      365      365           
Flag Coverage Δ
unittests 42.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dbe261...5a36034. Read the comment docs.

Use go get -u to upgrade dependencies.

Use git lfs to track the 186MB of *.a files for wasmtime that we don't
actually need.

Signed-off-by: Will Beason <willbeason@google.com>
@willbeason
Copy link
Member Author

Using git lfs to track the large "*.a" files.

Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willbeason willbeason merged commit 82a32ee into open-policy-agent:master Jul 14, 2021
@willbeason willbeason deleted the upgrade-dependencies branch July 14, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants