Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick empty parameters fix (#310) #131

Conversation

maxsmythe
Copy link
Contributor

Signed-off-by: Max Smythe smythe@google.com

@maxsmythe maxsmythe force-pushed the cherrypick-empty-params-schema-bugfix-to-0.2 branch from 8a081ed to 1623166 Compare August 2, 2021 21:27
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #131 (a84d87b) into release-0.2 (5c03494) will increase coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-0.2     #131      +/-   ##
===============================================
+ Coverage        44.26%   44.55%   +0.28%     
===============================================
  Files               30       30              
  Lines             2417     2415       -2     
===============================================
+ Hits              1070     1076       +6     
+ Misses            1022     1014       -8     
  Partials           325      325              
Flag Coverage Δ
unittests 44.55% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../apis/templates/v1beta1/zz_generated.conversion.go 23.07% <0.00%> (-1.13%) ⬇️
...apis/templates/v1alpha1/zz_generated.conversion.go 23.07% <0.00%> (-1.13%) ⬇️
...onstraint/pkg/apis/templates/v1beta1/conversion.go 61.90% <0.00%> (+16.45%) ⬆️
...nstraint/pkg/apis/templates/v1alpha1/conversion.go 61.90% <0.00%> (+16.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c03494...a84d87b. Read the comment docs.

@maxsmythe maxsmythe force-pushed the cherrypick-empty-params-schema-bugfix-to-0.2 branch from 1623166 to a84d87b Compare August 2, 2021 21:50
Signed-off-by: Max Smythe <smythe@google.com>
@maxsmythe maxsmythe force-pushed the cherrypick-empty-params-schema-bugfix-to-0.2 branch from a84d87b to 6982747 Compare August 2, 2021 21:55
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxsmythe maxsmythe merged commit 9f26912 into open-policy-agent:release-0.2 Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants