Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Client E2E tests more flexible #150

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Make Client E2E tests more flexible #150

merged 4 commits into from
Nov 30, 2021
+743 −730

Commits on Nov 29, 2021

  1. Rename e2e_tests to e2e_tests 

    Signed-off-by: Will Beason <willbeason@google.com>
    Will Beason committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    393fab3 View commit details
    Browse the repository at this point in the history

  2. Make tests more flexible 

    Refactor tests so that:

- it is possible to specify rego and libraries per-test
- all tests use their own Client
- the Probe type is no longer necessary

Signed-off-by: Will Beason <willbeason@google.com>
    Will Beason committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    cca3b68 View commit details
    Browse the repository at this point in the history

  3. Use cmp.Diff to check for response differences 

    This makes test output on failure more consistent and clearer.

Use per-test Context instead of one shared between all tests. This
removes another avenue of test crosstalk and allows us to test things
like behavior with cancellable contexts.

Make response order more, but not completely, deterministic. We don't
need response order to be more deterministic for tests than what I've
put here, and as-is will make the output of reviewing objects more
consistent. There are common edge cases where ordering is randomized,
but this can be fully fixed later.

Comment out the contents of TestRemoteClientE2E. This test is currently
skipped until we have a working remote to connect the remote Driver to.
I've added clarifying comments to explain what we'll want once this
exists.

Signed-off-by: Will Beason <willbeason@google.com>
    Will Beason committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    06bb9ec View commit details
    Browse the repository at this point in the history

  4. Make reviewer-suggested changes 

    Signed-off-by: Will Beason <willbeason@google.com>
    Will Beason committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    8e4b375 View commit details
    Browse the repository at this point in the history