Go113errors #160
Merged
Go113errors #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #160 +/- ##
==========================================
+ Coverage 43.95% 44.35% +0.40%
==========================================
Files 56 61 +5
Lines 3133 3206 +73
==========================================
+ Hits 1377 1422 +45
- Misses 1381 1413 +32
+ Partials 375 371 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
maxsmythe
approved these changes
Nov 20, 2021
willbeason
force-pushed
the
go113errors
branch
from
147810a
to
efe1d10
Compare
julianKatz
reviewed
Nov 24, 2021
constraint/pkg/client/errors.go
Outdated
|
|
||
| // Errors is a list of error. | ||
| // | ||
| // Deprecated: Use a structured result type if it is important to disambiguate |
There was a problem hiding this comment.
Does this mean have individual custom types for each error?
There was a problem hiding this comment.
It's very situational. If we want to report individual error codes, then we should use a structured error type. If we need to programmatically work with information the error can communicate, then the error should have that structure. In general we want to treat errors as black-box as possible unless we have a functional reason to do otherwise.
julianKatz
reviewed
Nov 29, 2021
julianKatz
approved these changes
Nov 29, 2021
added 15 commits
November 30, 2021 11:00
Remove ErrorList as it complicates code and results in repetitive errors as implemented. Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Also use cmp.Diff instead of reflect.DeepEqual Signed-off-by: Will Beason <willbeason@google.com>
Make tests easily adaptable to multiple targets Signed-off-by: Will Beason <willbeason@google.com>
Cover paths for go113 errors to ensure correct errors are returned. Signed-off-by: Will Beason <willbeason@google.com>
It would return that Constraints were unequal if they both had no specs. This is not intended behavior. Also add unit tests. Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Use RLock for reading and Lock for writing. As-is could result in concurrent reads and writes. Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
willbeason
force-pushed
the
go113errors
branch
from
54e8b74
to
a60513d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move pkg/client to use go113 errors conventions.
In general, move to using constant base errors and wrap them with fmt.Errorf. Also make tests check that the expected error is returned.
In many cases I've extended tests to make them more flexible to accommodate this. I've made the tests more flexible, but haven't added examples of using that flexibility (for example, a client working with multiple targets). I intend to do so in a separate PR.
Fix a few concurrency bugs - the RW mutex wasn't properly guarding writes vs. reads for constraints. Also consider two Constraints with empty Specs to be "Semantically equal" as it is valid for Constraints to have empty specs.