Provide IsUnrecognizedConstraintError #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For decoupling frameworks and gatekeeper error handling (which allows using go113 error conventinos in tests), I need to remove the dependence of gatekeeper on error types defined in frameworks so these may be changed safely to raw errors (where reasonable to do so). As an intermediate, I'm adding this function so that gatekeeper can continue to compile, and the implementation of this method may be switched out in frameworks. Signed-off-by: Will Beason <willbeason@google.com>
|
This is safe since gatekeeper doesn't actually use the type; it just performs a type check. |
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
- Coverage 43.97% 43.95% -0.03%
==========================================
Files 56 56
Lines 3131 3133 +2
==========================================
Hits 1377 1377
- Misses 1379 1381 +2
Partials 375 375
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For decoupling frameworks and gatekeeper error handling
(which allows using go113 error conventinos in tests), I need to remove
the dependence of gatekeeper on error types defined in frameworks so
these may be changed safely to raw errors (where reasonable to do so).
As an intermediate, I'm adding this function so that gatekeeper can
continue to compile, and the implementation of this method may be
switched out in frameworks.
Signed-off-by: Will Beason willbeason@google.com