Add driver.AddTemplate and driver.RemoveTemplate #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbeason
requested changes
Jan 7, 2022
willbeason
requested changes
Jan 10, 2022
becky-hd
force-pushed
the
171-addtemplate
branch
from
6fe36fd
to
9199320
Compare
willbeason
approved these changes
Jan 10, 2022
becky-hd
force-pushed
the
171-addtemplate
branch
from
a5ce605
to
4b35bc5
Compare
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
+ Coverage 45.20% 45.70% +0.50%
==========================================
Files 59 59
Lines 2796 2866 +70
==========================================
+ Hits 1264 1310 +46
- Misses 1290 1309 +19
- Partials 242 247 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
becky-hd
force-pushed
the
171-addtemplate
branch
3 times, most recently
from
9659fea
to
715fe96
Compare
Signed-off-by: Becky Huang <beckyhd@google.com>
…ng with client.CreateCRD Signed-off-by: Becky Huang <beckyhd@google.com>
export local.Driver set Externs for local.Driver within client.init move local.Driver PutModules and DeleteModules to private, deleted from drivers interface remove rego validation in client.CreateCRD Signed-off-by: Becky Huang <beckyhd@google.com>
Signed-off-by: Becky Huang <beckyhd@google.com>
becky-hd
force-pushed
the
171-addtemplate
branch
2 times, most recently
from
09c80a4
to
dd62459
Compare
… logic from client.CeateCRD (open-policy-agent#171) Signed-off-by: Becky Huang <beckyhd@google.com>
becky-hd
force-pushed
the
171-addtemplate
branch
from
dd62459
to
75008b5
Compare
|
@becky-hd looks like Gatekeeper tests are failing, is this expected? |
Yes, this PR removed validation in CreateCRD results some gatekeeper unit test failures. I opened open-policy-agent/gatekeeper#1788 as an immediate followup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#171
Allow client.AddTemplate calling
driver.AddTemplate(*templates.ConstraintTemplate)instead of parsing rego modules and callingdriver.PutModulesin client.client.CreateCRD uses the same parsing logic as part of template validation.