Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide driver AddConstraint and RemoveConstraint (#170) #182

Merged
merged 19 commits into from
Feb 4, 2022

Conversation

becky-hd
Copy link
Contributor

Signed-off-by: Becky Huang beckyhd@google.com

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #182 (f16b40a) into master (0f61a46) will increase coverage by 1.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   46.82%   47.89%   +1.07%     
==========================================
  Files          59       59              
  Lines        2819     2856      +37     
==========================================
+ Hits         1320     1368      +48     
+ Misses       1255     1239      -16     
- Partials      244      249       +5     
Flag Coverage Δ
unittests 47.89% <ø> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rks/constraint/pkg/client/drivers/remote/remote.go 29.26% <0.00%> (-0.49%) ⬇️
...eworks/constraint/pkg/client/drivers/local/args.go 76.19% <0.00%> (+1.19%) ⬆️
...y-agent/frameworks/constraint/pkg/client/client.go 73.66% <0.00%> (+1.67%) ⬆️
...works/constraint/pkg/client/drivers/local/local.go 70.00% <0.00%> (+5.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f61a46...f16b40a. Read the comment docs.

)

Signed-off-by: Becky Huang <beckyhd@google.com>
Signed-off-by: Becky Huang <beckyhd@google.com>
@becky-hd becky-hd changed the title [WIP] provide driver AddConstraint and RemoveConstraint (#170) provide driver AddConstraint and RemoveConstraint (#170) Jan 21, 2022
@becky-hd becky-hd changed the title provide driver AddConstraint and RemoveConstraint (#170) Provide driver AddConstraint and RemoveConstraint (#170) Jan 21, 2022
Signed-off-by: Becky Huang <beckyhd@google.com>
Signed-off-by: Becky Huang <beckyhd@google.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Becky Huang <beckyhd@google.com>
Signed-off-by: Becky Huang <beckyhd@google.com>
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willbeason willbeason merged commit 83f5c4f into open-policy-agent:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants