Fix typos and minor mistakes #196
Conversation
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=======================================
Coverage 46.82% 46.82%
=======================================
Files 59 59
Lines 2819 2819
=======================================
Hits 1320 1320
Misses 1255 1255
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| func (d *Driver) RemoveTemplate(ctx context.Context, templ *templates.ConstraintTemplate) error { | ||
| if err := validateTargets(templ); err != nil { | ||
| func (d *Driver) RemoveTemplate(templ *templates.ConstraintTemplate) error { | ||
| if len(templ.Spec.Targets) != 1 { |
There was a problem hiding this comment.
we probably want to return an error here to avoid failing silently if we forget to update this code when multi-target templates become a thing.
There was a problem hiding this comment.
If we return an error here, it's possible to get into a bad state where a template can't be deleted.
- Add valid Template
- Update Template to have multiple targets and wait for reconcile error
- Delete Template
As-is, this code is probably broken if someone does a similar change. I'd rather investigate and resolve in a dedicated PR than add the test/logic necessary to deal with this case here. Thus, I'd rather not modify the code and possibly introduce a bug (or modify the behavior of an existing one) and feel it safer to leave as-is.
There was a problem hiding this comment.
Also - this will be made moot by compiler sharding since we'll fix this anyway.
There was a problem hiding this comment.
Filed #197 in the compiler sharding milestone.
I ran inspect code to find typos and various unintentional bits of code. All of these changes are minor and don't result in any behavioral changes. Generally they show up as I'm editing code, and this makes them go away. Signed-off-by: Will Beason <willbeason@google.com>
I ran inspect code to find typos and various unintentional bits of code.
All of these changes are minor and don't result in any behavioral
changes. Generally they show up as I'm editing code, and this makes them
go away.
Signed-off-by: Will Beason willbeason@google.com