Remove direct storage.Path requirement in handler #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As-is requires a direct dependency of all callers on OPA. This PR changes the TargetHandler interface to accept storage path as a slice of strings instead of storage.Path. Functionally this changes nothing. Signed-off-by: Will Beason <willbeason@google.com>
added 2 commits
April 4, 2022 08:58
Signed-off-by: Will Beason <willbeason@google.com>
The workflow seems broken? Upgrading to fix. Signed-off-by: Will Beason <willbeason@google.com>
|
Gatekeeper test failing is expected since this changes the Target interface. |
Signed-off-by: Will Beason <willbeason@google.com>
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=======================================
Coverage 46.29% 46.29%
=======================================
Files 64 64
Lines 2819 2819
=======================================
Hits 1305 1305
Misses 1297 1297
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
maxsmythe
approved these changes
Apr 5, 2022
Signed-off-by: Will Beason <willbeason@google.com>
willbeason
force-pushed
the
remove-directo-opadep
branch
from
2fda96a
to
9ba2c13
Compare
added 2 commits
April 7, 2022 07:03
We've been at the threshold of about 5 minutes for a while, causing flaky tests. We recently enabled --race, which slows all tests and is likely what makes the tests run too slow in GitHub actions to run within the current 5 minute timeout. Note that in order to run, this target must create an entirely new Gatekeeper docker image with every invocation - Docker does not cache steps which involve file operations, so the image must be built from the ground up each time. This alone takes up a couple minutes of the runtime. As stated in the PR discussion, I see no performance degradation in the frameworks tests. I've had trouble getting Gatekeeper tests to pass at all from frameworks in GitHub, but every run I've done locally has worked. Signed-off-by: Will Beason <willbeason@google.com>
sozercan
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-is requires a direct dependency of all callers on OPA. This PR
changes the TargetHandler interface to accept storage path as a slice of
strings instead of storage.Path.
Functionally this changes nothing.
Signed-off-by: Will Beason willbeason@google.com