Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for future keyword #217

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

willbeason
Copy link
Member

Also add e2e tests that prove future works.

Signed-off-by: Will Beason willbeason@google.com

Also add e2e tests that prove future works.

Signed-off-by: Will Beason <willbeason@google.com>
@willbeason willbeason self-assigned this Apr 6, 2022
@willbeason
Copy link
Member Author

I have no explanation why Gatekeeper unit tests time out. It seems flaky?

Copy link
Member

@anderseknert anderseknert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@maxsmythe
Copy link
Contributor

re-running to see if they pass

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willbeason
Copy link
Member Author

Tested locally in Gatekeeper. The CI test just seems to take too long. I'd bet it's because we run every benchmark in Gatekeeper every time. I see no regressions on any impacted Frameworks benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants