feat: TLS support for External Data Providers #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 49.39% 50.22% +0.82%
==========================================
Files 64 64
Lines 4154 4255 +101
==========================================
+ Hits 2052 2137 +85
- Misses 1866 1879 +13
- Partials 236 239 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
maxsmythe
reviewed
May 19, 2022
chewong
force-pushed
the
external-data-provider-tls
branch
from
a78800b
to
b047790
Compare
willbeason
previously requested changes
May 26, 2022
chewong
force-pushed
the
external-data-provider-tls
branch
from
67caae8
to
89774ad
Compare
chewong
force-pushed
the
external-data-provider-tls
branch
from
8d5168d
to
42a8425
Compare
chewong
force-pushed
the
external-data-provider-tls
branch
from
42a8425
to
dc83a78
Compare
ritazh
reviewed
Jun 7, 2022
maxsmythe
reviewed
Jun 7, 2022
ritazh
reviewed
Jun 8, 2022
ritazh
reviewed
Jun 8, 2022
chewong
force-pushed
the
external-data-provider-tls
branch
2 times, most recently
from
44ab592
to
18159dd
Compare
ritazh
approved these changes
Jun 9, 2022
the gatekeeper test won't pass because this PR contains a minor breaking change (I changed the function signature of |
14 tasks
added 6 commits
June 21, 2022 18:41
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: GitHub <noreply@github.com>
chewong
force-pushed
the
external-data-provider-tls
branch
from
b283b3a
to
ecd4d23
Compare
Signed-off-by: GitHub <noreply@github.com>
chewong
force-pushed
the
external-data-provider-tls
branch
from
ecd4d23
to
7222ec1
Compare
maxsmythe
approved these changes
Jun 21, 2022
Signed-off-by: GitHub <noreply@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design doc: https://docs.google.com/document/d/1GjV3WeC2bgQ3j37_mMpY9hr7YOAqzSJ6jDSu-DVrcmU/edit#
This PR adds two new fields to the Provider CRD - caBundle and insecureTLSSkipVerify. If the provider is using HTTPS scheme for their provider and presents a valid caBundle, we will inject it into our HTTP client before making an external data request. We will also inject Gatekeeper's certificate into our HTTP client in case the provider wants to establish mutual trust.