Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Constraint schema validation error #230

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

willbeason
Copy link
Member

This is so that "gator verify" tests may check the schema of
Constraints. We need an error specific to schema validation so users can
explicitly test for this case.

Required for open-policy-agent/gatekeeper#1989

@willbeason willbeason self-assigned this Jun 3, 2022
@willbeason willbeason requested a review from sozercan June 3, 2022 15:29
Will Beason added 2 commits June 3, 2022 15:46
This is so that "gator verify" tests may check the schema of
Constraints. We need an error specific to schema validation so users can
explicitly test for this case.

Signed-off-by: Will Beason <willbeason@google.com>
Signed-off-by: Will Beason <willbeason@google.com>
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willbeason willbeason merged commit e8d94b2 into open-policy-agent:master Jun 3, 2022
@willbeason willbeason deleted the fail-schema branch June 3, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants