handle namespaceselector and empty namespaces #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsmythe
reviewed
Jun 28, 2019
maxsmythe
reviewed
Jul 2, 2019
There was a problem hiding this comment.
A few other things need to happen:
- We should decide whether autoreject_review is required or not
pkg/regolib/src.goneeds to be updated to handle autoreject_review- the check around should be updated to also validate autoreject_review
frameworks/constraint/pkg/client/client.go
Line 482 in 38085a7
- Once it's all wired together look at the contracts between these rules to make sure we're being consistent
maxsmythe
requested changes
Jul 2, 2019
|
Somehow didn't see that |
ritazh
force-pushed
the
fix-namespace-empty
branch
6 times, most recently
from
5f9072c
to
d281be1
Compare
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
ritazh
force-pushed
the
fix-namespace-empty
branch
from
65e0d82
to
d0129fa
Compare
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
maxsmythe
reviewed
Jul 4, 2019
maxsmythe
reviewed
Jul 5, 2019
Signed-off-by: Rita Zhang <rita.z.zhang@gmail.com>
acpana
pushed a commit
to acpana/frameworks
that referenced
this pull request
Dec 15, 2022
Remove workitems.md as project is being tracked using Github projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rita Zhang rita.z.zhang@gmail.com
Fixes open-policy-agent/gatekeeper#153