(Successor of #21) Add an allow list parameter, allowedSysctls, to the Forbidden sysctl constraint template #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…constraint template The `K8sPSPForbiddenSysctls` constraint template allows limiting sysctls available to pods using a deny list. This change adds another option, `allowedSysctls`, which allows a constraint to specify an allow list in addition to, or instead of, the deny list. The matching logic is as follows: 1. When specified, any sysctl not in the allow list is considered to be forbidden. 2. The allow list can be omitted. 3. The deny list takes precedence. Signed-off-by: Oren Shomron <shomron@gmail.com>
Signed-off-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
Signed-off-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
Signed-off-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
ordovicia
force-pushed
the
sysctl-allow-list
branch
from
014f9dd
to
a221e5a
Compare
nilekhc
reviewed
Nov 4, 2022
maxsmythe
reviewed
Nov 4, 2022
artifacthub/library/pod-security-policy/forbidden-sysctls/1.0.0/template.yaml
Outdated
Show resolved
Hide resolved
artifacthub/library/pod-security-policy/forbidden-sysctls/1.0.0/template.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
Signed-off-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
…ctls Signed-off-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
…sctls Signed-off-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
Signed-off-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
ordovicia
force-pushed
the
sysctl-allow-list
branch
from
aa4ba29
to
033c03f
Compare
maxsmythe
approved these changes
Nov 8, 2022
| violation[{"msg": msg, "details": {}}] { | ||
| sysctl := input.review.object.spec.securityContext.sysctls[_].name | ||
| not allowed_sysctl(sysctl) | ||
| msg := sprintf("The sysctl %v is not explictly allowed, pod: %v. Allowed sysctls: %v", [sysctl, input.review.object.metadata.name, input.parameters.allowedSysctls]) |
There was a problem hiding this comment.
We should add a comment that input.parameters.allowedSysctls in sprintf() is load-bearing.
Without that line, this change would be backwards-incompatible and that seems non-obvious. Adding a comment will help prevent accidentally breaking this requirement in the future.
There was a problem hiding this comment.
Sorry, what specifically do you mean by "load-bearing"?
ritazh
reviewed
Nov 8, 2022
artifacthub/library/pod-security-policy/forbidden-sysctls/1.0.0/README.md
Outdated
Show resolved
Hide resolved
ordovicia
force-pushed
the
sysctl-allow-list
branch
from
90164cb
to
533eb35
Compare
…s 1.0.0 Signed-off-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
ordovicia
force-pushed
the
sysctl-allow-list
branch
from
533eb35
to
4fc2715
Compare
|
Sorry, I accidentally removed a review request from @sozercan |
|
Hi, @maxsmythe @ritazh @sozercan cloud you please take a look again and merge this? |
ritazh
reviewed
Nov 22, 2022
Signed-off-by: Hidehito Yabuuchi <hdht.ybuc@gmail.com>
ordovicia
force-pushed
the
sysctl-allow-list
branch
from
95d768c
to
e56c451
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a successor of #21 and adds description for the new field, as per #21 (comment).
Quoting PR description from #21: